Remove zend_fcall_info_argn() and zend_fcall_info_argv()

Usage of these function heap allocates the zvals when they can already be used directly with an FCI

Author: Girgias

UPGRADING.INTERNALS

@@ -21,6 +21,8 @@ PHP 8.3 INTERNALS UPGRADE NOTES
   - zend_fcall_info_call()
   - zend_fcall_info_args_save()
   - zend_fcall_info_args_restore()
+  - zend_fcall_info_argn()
+  - zend_fcall_info_argv()
 
 ========================
 2. Build system changes

Zend/zend_API.c

@@ -4076,33 +4076,6 @@ ZEND_API void zend_fcall_info_argp(zend_fcall_info *fci, uint32_t argc, zval *ar
 }
 /* }}} */
 
-ZEND_API void zend_fcall_info_argv(zend_fcall_info *fci, uint32_t argc, va_list *argv) /* {{{ */
-{
-	zend_fcall_info_args_clear(fci, !argc);
-
-	if (argc) {
-		zval *arg;
-		fci->param_count = argc;
-		fci->params = (zval *) erealloc(fci->params, fci->param_count * sizeof(zval));
-
-		for (uint32_t i = 0; i < argc; ++i) {
-			arg = va_arg(*argv, zval *);
-			ZVAL_COPY(&fci->params[i], arg);
-		}
-	}
-}
-/* }}} */
-
-ZEND_API void zend_fcall_info_argn(zend_fcall_info *fci, uint32_t argc, ...) /* {{{ */
-{
-	va_list argv;
-
-	va_start(argv, argc);
-	zend_fcall_info_argv(fci, argc, &argv);
-	va_end(argv);
-}
-/* }}} */
-
 ZEND_API const char *zend_get_module_version(const char *module_name) /* {{{ */
 {
 	zend_string *lname;

Zend/zend_API.h

@@ -702,18 +702,6 @@ ZEND_API zend_result zend_fcall_info_args_ex(zend_fcall_info *fci, zend_function
  */
 ZEND_API void zend_fcall_info_argp(zend_fcall_info *fci, uint32_t argc, zval *argv);
 
-/** Set arguments in the zend_fcall_info struct taking care of refcount.
- * If argc is 0 the arguments which are set will be cleared, else pass
- * a variable amount of zval** arguments.
- */
-ZEND_API void zend_fcall_info_argv(zend_fcall_info *fci, uint32_t argc, va_list *argv);
-
-/** Set arguments in the zend_fcall_info struct taking care of refcount.
- * If argc is 0 the arguments which are set will be cleared, else pass
- * a variable amount of zval** arguments.
- */
-ZEND_API void zend_fcall_info_argn(zend_fcall_info *fci, uint32_t argc, ...);
-
 /* Can only return FAILURE if EG(active) is false during late engine shutdown.
  * If the call or call setup throws, EG(exception) will be set and the retval
  * will be UNDEF. Otherwise, the retval will be a non-UNDEF value. */