Don't use Zend signal handling in phpdbg

One difference between `zend_signal`, etc. and the underlying platform APIs like `signal`
is that the Zend versions did automatically unblock the signals for which a handler
is set. But looking at phpdbg, I don't think it is really the intention to unblock
SIGIO or SIGSEGV when installing handlers for them. There is no good reason why all
these signals would be blocked anyways.

Author: alexdowad

sapi/phpdbg/phpdbg.c

@@ -1242,7 +1242,7 @@ void phpdbg_signal_handler(int sig, siginfo_t *info, void *context) /* {{{ */
 				if (PHPDBG_G(sigsegv_bailout)) {
 					LONGJMP(*PHPDBG_G(sigsegv_bailout), FAILURE);
 				}
-				zend_sigaction(sig, &PHPDBG_G(old_sigsegv_signal), NULL);
+				sigaction(sig, &PHPDBG_G(old_sigsegv_signal), NULL);
 			}
 			break;
 	}
@@ -1371,8 +1371,6 @@ int main(int argc, char **argv) /* {{{ */
 # endif
 #endif
 
-	zend_signal_startup();
-
 	ini_entries = NULL;
 	ini_entries_len = 0;
 	ini_ignore = 0;
@@ -1669,10 +1667,6 @@ int main(int argc, char **argv) /* {{{ */
 			goto free_and_return;
 		}
 
-		zend_try {
-			zend_signal_activate();
-		} zend_end_try();
-
 		/* setup remote server if necessary */
 		if (cleaning <= 0 && listen > 0) {
 			server = phpdbg_open_socket(address, listen);
@@ -1681,15 +1675,15 @@ int main(int argc, char **argv) /* {{{ */
 			}
 
 #ifndef _WIN32
-			zend_sigaction(SIGIO, &sigio_struct, NULL);
+			sigaction(SIGIO, &sigio_struct, NULL);
 #endif
 
 			/* set remote flag to stop service shutting down upon quit */
 			remote = 1;
 #ifndef _WIN32
 		} else {
 
-			zend_signal(SIGHUP, phpdbg_sighup_handler);
+			signal(SIGHUP, phpdbg_sighup_handler);
 #endif
 		}
 
@@ -1758,23 +1752,23 @@ int main(int argc, char **argv) /* {{{ */
 		}
 
 #ifndef _WIN32
-		zend_try { zend_sigaction(SIGSEGV, &signal_struct, &PHPDBG_G(old_sigsegv_signal)); } zend_end_try();
-		zend_try { zend_sigaction(SIGBUS, &signal_struct, &PHPDBG_G(old_sigsegv_signal)); } zend_end_try();
+		sigaction(SIGSEGV, &signal_struct, &PHPDBG_G(old_sigsegv_signal));
+		sigaction(SIGBUS, &signal_struct, &PHPDBG_G(old_sigsegv_signal));
 #endif
 
 		/* do not install sigint handlers for remote consoles */
 		/* sending SIGINT then provides a decent way of shutting down the server */
 #ifndef _WIN32
 		if (listen < 0) {
 #endif
-			zend_try { zend_signal(SIGINT, phpdbg_sigint_handler); } zend_end_try();
+			signal(SIGINT, phpdbg_sigint_handler);
 #ifndef _WIN32
 		}
 
 		/* setup io here */
 		if (remote) {
 			PHPDBG_G(flags) |= PHPDBG_IS_REMOTE;
-			zend_signal(SIGPIPE, SIG_IGN);
+			signal(SIGPIPE, SIG_IGN);
 		}
 		PHPDBG_G(io)[PHPDBG_STDIN].ptr = stdin;
 		PHPDBG_G(io)[PHPDBG_STDIN].fd = fileno(stdin);
@@ -2107,7 +2101,7 @@ int main(int argc, char **argv) /* {{{ */
 		}
 
 #ifndef _WIN32
-		/* force override (no zend_signals) to prevent crashes due to signal recursion in SIGSEGV/SIGBUS handlers */
+		/* restore default SIGSEGV/SIGBUS handlers */
 		signal(SIGSEGV, SIG_DFL);
 		signal(SIGBUS, SIG_DFL);
 

sapi/phpdbg/phpdbg.h

@@ -43,7 +43,6 @@
 #include "zend_globals.h"
 #include "zend_ini_scanner.h"
 #include "zend_stream.h"
-#include "zend_signal.h"
 #if !defined(_WIN32) && !defined(ZEND_SIGNALS)
 #	include <signal.h>
 #elif defined(PHP_WIN32)