Avoid pointless duplication in _end_element_handler

nielsdos · nielsdos · commit 87599717c9ce · 2024-07-04T02:21:59.000-07:00
diff --git a/ext/xml/compat.c b/ext/xml/compat.c
@@ -184,7 +184,6 @@ _start_element_handler_ns(void *user, const xmlChar *name, const xmlChar *prefix
 static void
 _end_element_handler(void *user, const xmlChar *name)
 {
-	xmlChar    *qualified_name;
 	XML_Parser  parser = (XML_Parser) user;
 
 	if (parser->h_end_element == NULL) {
@@ -198,11 +197,7 @@ _end_element_handler(void *user, const xmlChar *name)
 		return;
 	}
 
-	qualified_name = xmlStrdup(name);
-
-	parser->h_end_element(parser->user, (const XML_Char *) qualified_name);
-
-	xmlFree(qualified_name);
+	parser->h_end_element(parser->user, (const XML_Char *) name);
 }
 
 static void

Original file line number	Diff line number	Diff line change
`@@ -184,7 +184,6 @@ _start_element_handler_ns(void user, const xmlChar name, const xmlChar *prefix`
`184`	`184`	`static void`
`185`	`185`	`_end_element_handler(void user, const xmlChar name)`
`186`	`186`	`{`
`187`		`- xmlChar *qualified_name;`
`188`	`187`	`XML_Parser parser = (XML_Parser) user;`
`189`	`188`
`190`	`189`	`if (parser->h_end_element == NULL) {`
`@@ -198,11 +197,7 @@ _end_element_handler(void user, const xmlChar name)`
`198`	`197`	`return;`
`199`	`198`	`}`
`200`	`199`
`201`		`- qualified_name = xmlStrdup(name);`
`202`		`-`
`203`		`- parser->h_end_element(parser->user, (const XML_Char *) qualified_name);`
`204`		`-`
`205`		`- xmlFree(qualified_name);`
	`200`	`+ parser->h_end_element(parser->user, (const XML_Char *) name);`
`206`	`201`	`}`
`207`	`202`
`208`	`203`	`static void`