Skip to content

Commit 8742276

Browse files
committed
abstain from using xmlCleanupParser
Depending on circumstances, usage of xmlCleanupParser can affect the thread local storage, or even cause crashes in single threaded programs. On shutdown the memory will be freed anyway, however not using xmlCleanupParser helps to avoid possible shutdown crashes.
1 parent 4ff333f commit 8742276

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

ext/libxml/libxml.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -752,7 +752,7 @@ PHP_LIBXML_API void php_libxml_shutdown(void)
752752
#if defined(LIBXML_SCHEMAS_ENABLED)
753753
xmlRelaxNGCleanupTypes();
754754
#endif
755-
xmlCleanupParser();
755+
/* xmlCleanupParser(); */
756756
zend_hash_destroy(&php_libxml_exports);
757757

758758
xmlSetExternalEntityLoader(_php_libxml_default_entity_loader);

0 commit comments

Comments
 (0)