fixup! Handle zero seed in Xoshiro256**

TimWolla · TimWolla · commit 87312a0101cc · 2022-08-04T23:43:25.000+02:00
diff --git a/ext/random/engine_xoshiro256starstar.c b/ext/random/engine_xoshiro256starstar.c
@@ -225,7 +225,7 @@ PHP_METHOD(Random_Engine_Xoshiro256StarStar, __construct)
 					}
 				}
 
-				if (t[0] == 0 && t[1] == 0 && t[2] == 0 && t[3] == 0) {
+				if (UNEXPECTED(t[0] == 0 && t[1] == 0 && t[2] == 0 && t[3] == 0)) {
 					zend_argument_value_error(1, "must not consist entirely of NUL bytes");
 					RETURN_THROWS();
 				}

Original file line number	Diff line number	Diff line change
`@@ -225,7 +225,7 @@ PHP_METHOD(Random_Engine_Xoshiro256StarStar, __construct)`
`225`	`225`	`}`
`226`	`226`	`}`
`227`	`227`
`228`		`- if (t[0] == 0 && t[1] == 0 && t[2] == 0 && t[3] == 0) {`
	`228`	`+ if (UNEXPECTED(t[0] == 0 && t[1] == 0 && t[2] == 0 && t[3] == 0)) {`
`229`	`229`	`zend_argument_value_error(1, "must not consist entirely of NUL bytes");`
`230`	`230`	`RETURN_THROWS();`
`231`	`231`	`}`