Fix GH-17017: OOB read when starting up file cache (GH-17023)

cmb69 · web-flow · commit 85f7e5477a5c · 2024-12-03T12:13:53.000+01:00
`zend_system_id` is not zero-terminated; as such we must constrain the
number of characters we print.
diff --git a/ext/opcache/ZendAccelerator.c b/ext/opcache/ZendAccelerator.c
@@ -3331,7 +3331,7 @@ static zend_result accel_post_startup(void)
 	}
 
 	if ( ZCG(accel_directives).file_cache ) {
-		zend_accel_error(ACCEL_LOG_INFO, "opcache.file_cache running with PHP build ID: %s", zend_system_id);
+		zend_accel_error(ACCEL_LOG_INFO, "opcache.file_cache running with PHP build ID: %.32s", zend_system_id);
 
 		zend_stat_t buf = {0};
 

Original file line number	Diff line number	Diff line change
`@@ -3331,7 +3331,7 @@ static zend_result accel_post_startup(void)`
`3331`	`3331`	`}`
`3332`	`3332`
`3333`	`3333`	`if ( ZCG(accel_directives).file_cache ) {`
`3334`		`- zend_accel_error(ACCEL_LOG_INFO, "opcache.file_cache running with PHP build ID: %s", zend_system_id);`
	`3334`	`+ zend_accel_error(ACCEL_LOG_INFO, "opcache.file_cache running with PHP build ID: %.32s", zend_system_id);`
`3335`	`3335`
`3336`	`3336`	`zend_stat_t buf = {0};`
`3337`	`3337`