debug: set ZEND_DEBUG=1 for Windows build

nielsdos · nielsdos · commit 854c37d7fa2f · 2023-02-19T23:22:49.000+01:00
diff --git a/win32/build/confutils.js b/win32/build/confutils.js
@@ -3436,10 +3436,10 @@ function toolset_setup_build_mode()
 		}
 		ADD_FLAG("CFLAGS", "/LD /MD");
 		if (PHP_SANITIZER == "yes" && CLANG_TOOLSET) {
-			ADD_FLAG("CFLAGS", "/Od /D NDebug /D NDEBUG /D ZEND_WIN32_NEVER_INLINE /D ZEND_DEBUG=0");
+			ADD_FLAG("CFLAGS", "/Od /D _DEBUG /D ZEND_WIN32_NEVER_INLINE /D ZEND_DEBUG=1");
 		} else {
 			// Equivalent to Release_TSInline build -> best optimization
-			ADD_FLAG("CFLAGS", "/Ox /D NDebug /D NDEBUG /GF /D ZEND_DEBUG=0");
+			ADD_FLAG("CFLAGS", "/Ox /D _DEBUG /GF /D ZEND_DEBUG=1");
 		}
 
 		// if you have VS.Net /GS hardens the binary against buffer overruns

Original file line number	Diff line number	Diff line change
`@@ -3436,10 +3436,10 @@ function toolset_setup_build_mode()`
`3436`	`3436`	`}`
`3437`	`3437`	`ADD_FLAG("CFLAGS", "/LD /MD");`
`3438`	`3438`	`if (PHP_SANITIZER == "yes" && CLANG_TOOLSET) {`
`3439`		`- ADD_FLAG("CFLAGS", "/Od /D NDebug /D NDEBUG /D ZEND_WIN32_NEVER_INLINE /D ZEND_DEBUG=0");`
	`3439`	`+ ADD_FLAG("CFLAGS", "/Od /D _DEBUG /D ZEND_WIN32_NEVER_INLINE /D ZEND_DEBUG=1");`
`3440`	`3440`	`} else {`
`3441`	`3441`	`// Equivalent to Release_TSInline build -> best optimization`
`3442`		`- ADD_FLAG("CFLAGS", "/Ox /D NDebug /D NDEBUG /GF /D ZEND_DEBUG=0");`
	`3442`	`+ ADD_FLAG("CFLAGS", "/Ox /D _DEBUG /GF /D ZEND_DEBUG=1");`
`3443`	`3443`	`}`
`3444`	`3444`
`3445`	`3445`	`// if you have VS.Net /GS hardens the binary against buffer overruns`