Skip to content

Commit 84cd2a9

Browse files
committed
Add some stub related todo comments
1 parent 8b70a7d commit 84cd2a9

File tree

6 files changed

+9
-9
lines changed

6 files changed

+9
-9
lines changed

Zend/zend_exceptions.stub.php

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ interface Throwable extends Stringable
77
public function getMessage(): string;
88

99
/** @return int */
10-
public function getCode();
10+
public function getCode(); // TODO add proper type (i.e. int|string)
1111

1212
public function getFile(): string;
1313

@@ -32,7 +32,7 @@ class Exception implements Throwable
3232
* Intentionally left untyped for BC reasons
3333
* @var int
3434
*/
35-
protected $code = 0;
35+
protected $code = 0; // TODO add proper type (i.e. int|string)
3636
protected string $file = "";
3737
protected int $line = 0;
3838
private array $trace = [];
@@ -48,7 +48,7 @@ public function __wakeup(): void {}
4848
final public function getMessage(): string {}
4949

5050
/** @return int */
51-
final public function getCode() {}
51+
final public function getCode() {} // TODO add proper type (i.e. int|string)
5252

5353
final public function getFile(): string {}
5454

@@ -91,7 +91,7 @@ class Error implements Throwable
9191
* Intentionally left untyped for BC reasons
9292
* @var int
9393
*/
94-
protected $code = 0;
94+
protected $code = 0; // TODO add proper type (i.e. int|string)
9595
protected string $file = "";
9696
protected int $line;
9797
private array $trace = [];

Zend/zend_exceptions_arginfo.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
/* This is a generated file, edit the .stub.php file instead.
2-
* Stub hash: 9d1c2027ebd14e621d9b5b79056ba7300a455be8 */
2+
* Stub hash: bee3fd13c5d5a6d09e217452998389d1b595157a */
33

44
ZEND_BEGIN_ARG_WITH_RETURN_TYPE_INFO_EX(arginfo_class_Throwable_getMessage, 0, 0, IS_STRING, 0)
55
ZEND_END_ARG_INFO()

ext/dom/php_dom.stub.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -568,7 +568,7 @@ final class DOMException extends Exception
568568
* Intentionally left untyped for BC reasons
569569
* @var int
570570
*/
571-
public $code = 0;
571+
public $code = 0; // TODO add proper type (i.e. int|string)
572572
}
573573

574574
class DOMText extends DOMCharacterData

ext/dom/php_dom_arginfo.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
/* This is a generated file, edit the .stub.php file instead.
2-
* Stub hash: 74698bea9c5e0635cf91345e8512b9677489510c */
2+
* Stub hash: 875805a57dada3ba8aceaa54508589d994855f31 */
33

44
ZEND_BEGIN_ARG_WITH_RETURN_OBJ_INFO_EX(arginfo_dom_import_simplexml, 0, 1, DOMElement, 0)
55
ZEND_ARG_TYPE_INFO(0, node, IS_OBJECT, 0)

ext/pdo/pdo.stub.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
class PDOException extends RuntimeException
66
{
77
/** @var int|string */
8-
protected $code = 0;
8+
protected $code = 0; // TODO add proper type
99
public ?array $errorInfo = null;
1010
}
1111

ext/pdo/pdo_arginfo.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
/* This is a generated file, edit the .stub.php file instead.
2-
* Stub hash: 8d975a20d009e827f8d72ac19b94b55870b6bf9c */
2+
* Stub hash: dc41dddeea1ae117c6f2f3447afb29bf6623b757 */
33

44
ZEND_BEGIN_ARG_WITH_RETURN_TYPE_INFO_EX(arginfo_pdo_drivers, 0, 0, IS_ARRAY, 0)
55
ZEND_END_ARG_INFO()

0 commit comments

Comments
 (0)