Skip to content

Commit 8442221

Browse files
committed
Add/remove some comments
1 parent 0dc8807 commit 8442221

File tree

2 files changed

+10
-2
lines changed

2 files changed

+10
-2
lines changed

Zend/zend_compile.c

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8118,6 +8118,7 @@ void zend_compile_top_stmt(zend_ast *ast) /* {{{ */
81188118
}
81198119

81208120
/* Compile remainder */
8121+
/* todo: loop to catch any non-consecutive type declarations */
81218122
for (p = last_decl; p < end; ++p) {
81228123
zend_compile_top_stmt(*p);
81238124
}

Zend/zend_inheritance.c

Lines changed: 9 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -245,6 +245,12 @@ int _check_zce_variance(
245245
}
246246
}
247247

248+
/* This int return is not a boolean, but will often be treated this way.
249+
* * 0 means there is definitely an error.
250+
* * 1 means there are definitely not any errors.
251+
* * -1 means there are no known errors but it is not known to be good
252+
* either (there is not enough information at the moment).
253+
*/
248254
static
249255
int _check_inherited_arg_info(
250256
const zend_function *fe, zend_arg_info *fe_arg_info,
@@ -284,8 +290,9 @@ int _check_inherited_arg_info(
284290
if (fe_ce && proto_ce) {
285291
code = _check_zce_variance(fe_ce, proto_ce, variance);
286292
} else {
287-
/* todo: delay to runtime. How? */
288-
/* Don't break bug62441! */
293+
/* The -1 will still be considered "truthy". It means there
294+
* is not enough information at the moment, but there are
295+
* not any known errors either. */
289296
code = -1;
290297
}
291298
} else {

0 commit comments

Comments
 (0)