Remove some RETURN_FALSE on exception

nikic · nikic · commit 817fbe8186d3 · 2019-10-29T13:36:03.000+01:00
diff --git a/ext/standard/proc_open.c b/ext/standard/proc_open.c
@@ -245,7 +245,7 @@ PHP_FUNCTION(proc_terminate)
 	ZEND_PARSE_PARAMETERS_END();
 
 	if ((proc = (struct php_process_handle *)zend_fetch_resource(Z_RES_P(zproc), "process", le_proc_open)) == NULL) {
-		RETURN_FALSE;
+		return;
 	}
 
 #ifdef PHP_WIN32
@@ -276,7 +276,7 @@ PHP_FUNCTION(proc_close)
 	ZEND_PARSE_PARAMETERS_END();
 
 	if ((proc = (struct php_process_handle *)zend_fetch_resource(Z_RES_P(zproc), "process", le_proc_open)) == NULL) {
-		RETURN_FALSE;
+		return;
 	}
 
 	FG(pclose_wait) = 1;
@@ -306,7 +306,7 @@ PHP_FUNCTION(proc_get_status)
 	ZEND_PARSE_PARAMETERS_END();
 
 	if ((proc = (struct php_process_handle *)zend_fetch_resource(Z_RES_P(zproc), "process", le_proc_open)) == NULL) {
-		RETURN_FALSE;
+		return;
 	}
 
 	array_init(return_value);

Original file line number	Diff line number	Diff line change
`@@ -245,7 +245,7 @@ PHP_FUNCTION(proc_terminate)`
`245`	`245`	`ZEND_PARSE_PARAMETERS_END();`
`246`	`246`
`247`	`247`	`if ((proc = (struct php_process_handle *)zend_fetch_resource(Z_RES_P(zproc), "process", le_proc_open)) == NULL) {`
`248`		`- RETURN_FALSE;`
	`248`	`+ return;`
`249`	`249`	`}`
`250`	`250`
`251`	`251`	`#ifdef PHP_WIN32`
`@@ -276,7 +276,7 @@ PHP_FUNCTION(proc_close)`
`276`	`276`	`ZEND_PARSE_PARAMETERS_END();`
`277`	`277`
`278`	`278`	`if ((proc = (struct php_process_handle *)zend_fetch_resource(Z_RES_P(zproc), "process", le_proc_open)) == NULL) {`
`279`		`- RETURN_FALSE;`
	`279`	`+ return;`
`280`	`280`	`}`
`281`	`281`
`282`	`282`	`FG(pclose_wait) = 1;`
`@@ -306,7 +306,7 @@ PHP_FUNCTION(proc_get_status)`
`306`	`306`	`ZEND_PARSE_PARAMETERS_END();`
`307`	`307`
`308`	`308`	`if ((proc = (struct php_process_handle *)zend_fetch_resource(Z_RES_P(zproc), "process", le_proc_open)) == NULL) {`
`309`		`- RETURN_FALSE;`
	`309`	`+ return;`
`310`	`310`	`}`
`311`	`311`
`312`	`312`	`array_init(return_value);`