Cleanup unused variable in php_dom.c (#12463)

nielsdos · web-flow · commit 7f46c87fa1ae · 2023-10-17T22:46:05.000+02:00
diff --git a/ext/dom/php_dom.c b/ext/dom/php_dom.c
@@ -968,11 +968,6 @@ void dom_xpath_objects_free_storage(zend_object *object)
 void dom_objects_free_storage(zend_object *object)
 {
 	dom_object *intern = php_dom_obj_from_obj(object);
-#if defined(__GNUC__) && __GNUC__ >= 3
-	int retcount __attribute__((unused)); /* keep compiler quiet */
-#else
-	int retcount;
-#endif
 
 	zend_object_std_dtor(&intern->std);
 
@@ -981,7 +976,7 @@ void dom_objects_free_storage(zend_object *object)
 			php_libxml_node_decrement_resource((php_libxml_node_object *) intern);
 		} else {
 			php_libxml_decrement_node_ptr((php_libxml_node_object *) intern);
-			retcount = php_libxml_decrement_doc_ref((php_libxml_node_object *)intern);
+			php_libxml_decrement_doc_ref((php_libxml_node_object *) intern);
 		}
 		intern->ptr = NULL;
 	}

Original file line number	Diff line number	Diff line change
`@@ -968,11 +968,6 @@ void dom_xpath_objects_free_storage(zend_object *object)`
`968`	`968`	`void dom_objects_free_storage(zend_object *object)`
`969`	`969`	`{`
`970`	`970`	`dom_object *intern = php_dom_obj_from_obj(object);`
`971`		`-#if defined(__GNUC__) && __GNUC__ >= 3`
`972`		`- int retcount __attribute__((unused)); /* keep compiler quiet */`
`973`		`-#else`
`974`		`- int retcount;`
`975`		`-#endif`
`976`	`971`
`977`	`972`	`zend_object_std_dtor(&intern->std);`
`978`	`973`
`@@ -981,7 +976,7 @@ void dom_objects_free_storage(zend_object *object)`
`981`	`976`	`php_libxml_node_decrement_resource((php_libxml_node_object *) intern);`
`982`	`977`	`} else {`
`983`	`978`	`php_libxml_decrement_node_ptr((php_libxml_node_object *) intern);`
`984`		`- retcount = php_libxml_decrement_doc_ref((php_libxml_node_object *)intern);`
	`979`	`+ php_libxml_decrement_doc_ref((php_libxml_node_object *) intern);`
`985`	`980`	`}`
`986`	`981`	`intern->ptr = NULL;`
`987`	`982`	`}`