Revert "Make ReflectionUnionType final"

nikic · nikic · commit 7f462c97f90f · 2020-10-26T08:51:06.000+01:00
This reverts commit ef6adb4. Per Ondrej's comment, this is already being used by BetterReflection adaptors, ugh.
diff --git a/ext/reflection/php_reflection.c b/ext/reflection/php_reflection.c
@@ -6529,7 +6529,6 @@ PHP_MINIT_FUNCTION(reflection) /* {{{ */
 
 	INIT_CLASS_ENTRY(_reflection_entry, "ReflectionUnionType", class_ReflectionUnionType_methods);
 	reflection_init_class_handlers(&_reflection_entry);
-	_reflection_entry.ce_flags |= ZEND_ACC_FINAL | ZEND_ACC_NO_DYNAMIC_PROPERTIES;
 	reflection_union_type_ptr = zend_register_internal_class_ex(&_reflection_entry, reflection_type_ptr);
 
 	INIT_CLASS_ENTRY(_reflection_entry, "ReflectionMethod", class_ReflectionMethod_methods);
diff --git a/ext/reflection/php_reflection.stub.php b/ext/reflection/php_reflection.stub.php
@@ -568,7 +568,7 @@ public function getName() {}
     public function isBuiltin() {}
 }
 
-final class ReflectionUnionType extends ReflectionType
+class ReflectionUnionType extends ReflectionType
 {
     public function getTypes(): array {}
 }
diff --git a/ext/reflection/php_reflection_arginfo.h b/ext/reflection/php_reflection_arginfo.h
@@ -1,5 +1,5 @@
 /* This is a generated file, edit the .stub.php file instead.
- * Stub hash: 4b759a151e33cdd91e414ac332e3a2760534a1d6 */
+ * Stub hash: ec7607b8087ddd4297bf51cc4072465d2a0f27af */
 
 ZEND_BEGIN_ARG_INFO_EX(arginfo_class_Reflection_getModifierNames, 0, 0, 1)
 	ZEND_ARG_TYPE_INFO(0, modifiers, IS_LONG, 0)

Original file line number	Diff line number	Diff line change
`@@ -568,7 +568,7 @@ public function getName() {}`
`568`	`568`	`public function isBuiltin() {}`
`569`	`569`	`}`
`570`	`570`
`571`		`-final class ReflectionUnionType extends ReflectionType`
	`571`	`+class ReflectionUnionType extends ReflectionType`
`572`	`572`	`{`
`573`	`573`	`public function getTypes(): array {}`
`574`	`574`	`}`