Fix list() assignment in array literals

Fixes GH-11320

Author: iluuu1994

Zend/tests/gh11320_1.phpt

@@ -0,0 +1,28 @@
+--TEST--
+GH-11320: Array literals can contain list() assignments
+--FILE--
+<?php
+$index = 1;
+function getList() { return [2, 3]; }
+var_dump([$index => list($x, $y) = getList()]);
+var_dump([$index => [$x, $y] = getList()]);
+?>
+--EXPECT--
+array(1) {
+  [1]=>
+  array(2) {
+    [0]=>
+    int(2)
+    [1]=>
+    int(3)
+  }
+}
+array(1) {
+  [1]=>
+  array(2) {
+    [0]=>
+    int(2)
+    [1]=>
+    int(3)
+  }
+}

Zend/tests/gh11320_2.phpt

@@ -0,0 +1,12 @@
+--TEST--
+GH-11320: list() expressions can contain magic constants
+--FILE--
+<?php
+[list(__FILE__ => $foo) = [__FILE__ => 'foo']];
+var_dump($foo);
+[[__FILE__ => $foo] = [__FILE__ => 'foo']];
+var_dump($foo);
+?>
+--EXPECT--
+string(3) "foo"
+string(3) "foo"

Zend/tests/gh11320_3.phpt

@@ -0,0 +1,8 @@
+--TEST--
+GH-11320: list() must not appear as a standalone array element
+--FILE--
+<?php
+[list($a)];
+?>
+--EXPECTF--
+Fatal error: Cannot use list() as standalone expression in %s on line %d

Zend/zend_compile.c

@@ -10617,10 +10617,23 @@ static void zend_eval_const_expr_inner(zend_ast **ast_ptr, void *ctx) /* {{{ */
 	 * differenciate between literal class names and expressions that evaluate to strings. Strings
 	 * are not actually allowed in ::class expressions.
 	 * 
-	 * ZEND_AST_COALESCE and ZEND_AST_CONDITIONAL will manually evaluate only the children for the
-	 * taken paths. */
-	if (ast->kind != ZEND_AST_CLASS_NAME && ast->kind != ZEND_AST_COALESCE && ast->kind != ZEND_AST_CONDITIONAL) {
-		zend_ast_apply(ast, zend_eval_const_expr_inner, ctx);
+	 * ZEND_AST_ARRAY, ZEND_AST_COALESCE and ZEND_AST_CONDITIONAL will manually evaluate only the
+	 * children for the taken paths.
+	 *
+	 * The lhs of ZEND_AST_ASSIGN can contain list() expressions which should not be evaluated. Skip
+	 * assignments entirely. They can't appear in constant expressions, and if inside arrays they
+	 * will be re-evaluated. */
+	switch (ast->kind) {
+		case ZEND_AST_ARRAY:
+		case ZEND_AST_ASSIGN:
+		case ZEND_AST_CLASS_NAME:
+		case ZEND_AST_COALESCE:
+		case ZEND_AST_CONDITIONAL:
+			break;
+		default:
+			if (!zend_ast_is_special(ast)) {
+				zend_ast_apply(ast, zend_eval_const_expr_inner, ctx);
+			}
 	}
 
 	switch (ast->kind) {