Skip to content

Commit 7edc5e5

Browse files
committed
Fix skip reasons
These tests fail on Windows for different reasons, but not because symlinks, links, or lstat() would not be supported on Windows generally.
1 parent 68293b1 commit 7edc5e5

10 files changed

+9
-12
lines changed

ext/standard/tests/file/001.phpt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ File type functions
33
--SKIPIF--
44
<?php
55
if (substr(PHP_OS, 0, 3) == 'WIN') {
6-
die('skip no symlinks on Windows');
6+
die('skip not for Windows');
77
}
88
if (getenv("SKIP_SLOW_TESTS")) die("skip slow test");
99
?>

ext/standard/tests/file/bug39367.phpt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ Bug #39367 (clearstatcache() doesn't clear realpath cache)
33
--SKIPIF--
44
<?php
55
if (substr(PHP_OS, 0, 3) == 'WIN') {
6-
die('skip no symlinks on Windows');
6+
die('skip not for Windows');
77
}
88
?>
99
--FILE--

ext/standard/tests/file/fflush_variation2.phpt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ Test fflush() function: usage variations - links as resource
33
--SKIPIF--
44
<?php
55
if( substr(PHP_OS, 0, 3) == 'WIN')
6-
die("skip Links not valid on Windows");
6+
die("skip not for Windows");
77
?>
88
--FILE--
99
<?php

ext/standard/tests/file/fflush_variation3.phpt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ Test fflush() function: usage variations - hard links as resource
33
--SKIPIF--
44
<?php
55
if( substr(PHP_OS, 0, 3) == 'WIN')
6-
die("skip Links not valid on Windows");
6+
die("skip not for Windows");
77
?>
88
--FILE--
99
<?php

ext/standard/tests/file/filetype_variation.phpt

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,9 +2,6 @@
22
Test filetype() function: Variations
33
--SKIPIF--
44
<?php
5-
if (substr(PHP_OS, 0, 3) == 'WIN') {
6-
die('skip no link()/symlink() on Windows');
7-
}
85
if (!function_exists("posix_mkfifo")) {
96
die("skip no posix_mkfifo()");
107
}

ext/standard/tests/file/lstat_stat_basic.phpt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ Test lstat() & stat() functions: basic functionality
44
<?php
55
if (getenv("SKIP_SLOW_TESTS")) die("skip slow test");
66
if (substr(PHP_OS, 0, 3) == 'WIN') {
7-
die('skip.. lstat() not available on Windows');
7+
die('skip not for Windows');
88
}
99
?>
1010
--FILE--

ext/standard/tests/file/mkdir-002.phpt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ mkdir(dir, 0777) tests
33
--SKIPIF--
44
<?php
55
if (substr(PHP_OS, 0, 3) == 'WIN') {
6-
die('skip no symlinks on Windows');
6+
die('skip not for Windows');
77
}
88
?>
99
--FILE--

ext/standard/tests/file/realpath_basic4.phpt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ Test realpath() with relative paths
33
--SKIPIF--
44
<?php
55
if (substr(PHP_OS, 0, 3) == 'WIN') {
6-
die('skip no symlinks on Windows');
6+
die('skip not for Windows');
77
}
88
?>
99
--FILE--

ext/standard/tests/file/symlink.phpt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ symlink() & friends
33
--SKIPIF--
44
<?php
55
if (substr(PHP_OS, 0, 3) == 'WIN') {
6-
die('skip no symlinks on Windows');
6+
die('skip not for Windows');
77
}
88
?>
99
--FILE--

ext/standard/tests/file/symlink_to_symlink.phpt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ symlink() using a relative path, and symlink() to a symlink
33
--SKIPIF--
44
<?php
55
if (substr(PHP_OS, 0, 3) == 'WIN') {
6-
die('skip no symlinks on Windows');
6+
die('skip not for Windows');
77
}
88
?>
99
--FILE--

0 commit comments

Comments
 (0)