Skip to content

Commit 7cb1a70

Browse files
committed
Merge branch 'PHP-7.4'
* PHP-7.4: Fix #79145: openssl memory leak
2 parents 1f1a7ec + 16a8a60 commit 7cb1a70

File tree

2 files changed

+26
-2
lines changed

2 files changed

+26
-2
lines changed

ext/openssl/openssl.c

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4445,7 +4445,6 @@ PHP_FUNCTION(openssl_pkey_get_public)
44454445
RETURN_FALSE;
44464446
}
44474447
ZVAL_RES(return_value, res);
4448-
Z_ADDREF_P(return_value);
44494448
}
44504449
/* }}} */
44514450

@@ -4487,7 +4486,6 @@ PHP_FUNCTION(openssl_pkey_get_private)
44874486
RETURN_FALSE;
44884487
}
44894488
ZVAL_RES(return_value, res);
4490-
Z_ADDREF_P(return_value);
44914489
}
44924490

44934491
/* }}} */

ext/openssl/tests/bug79145.phpt

Lines changed: 26 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,26 @@
1+
--TEST--
2+
Bug #79145 (openssl memory leak)
3+
--SKIPIF--
4+
<?php
5+
if (!extension_loaded('openssl')) die('skip openssl extension not available');
6+
if (getenv('SKIP_SLOW_TESTS')) die('skip slow test');
7+
?>
8+
--FILE--
9+
<?php
10+
$b = '-----BEGIN PUBLIC KEY-----
11+
MIGfMA0GCSqGSIb3DQEBAQUAA4GNADCBiQKBgQDaFhc31WeskqxwI+Si5R/fZrLK
12+
pJOlABiI3RZfKCHJVrXl3IvcHDFM/BHKUJoSi/ee8GS9iw0G4Z1eCzJdthXxHARh
13+
j85Q5OliVxOdB1LoTOsOmfFf/fdvpU3DsOWsDKlVrL41MHxXorwrwOiys/r/gv2d
14+
C9C4JmhTOjBVAK8SewIDAQAC
15+
-----END PUBLIC KEY-----';
16+
17+
$start = memory_get_usage(true);
18+
for ($i = 0; $i < 100000; $i++) {
19+
$a = openssl_get_publickey($b);
20+
openssl_free_key($a);
21+
}
22+
$end = memory_get_usage(true);
23+
var_dump($end <= 1.1 * $start);
24+
?>
25+
--EXPECT--
26+
bool(true)

0 commit comments

Comments
 (0)