Fix precedence issue causing sub-second timeouts to be 0 in

rlerdorf · rlerdorf · commit 7b42cdf95ee9 · 2019-05-21T14:44:11.000-07:00
curl_multi_select
diff --git a/ext/curl/multi.c b/ext/curl/multi.c
@@ -233,7 +233,7 @@ PHP_FUNCTION(curl_multi_select)
 	}
 
 #if LIBCURL_VERSION_NUM >= 0x071c00 /* Available since 7.28.0 */
-	error = curl_multi_wait(mh->multi, NULL, 0, (unsigned long) timeout * 1000.0, &numfds);
+	error = curl_multi_wait(mh->multi, NULL, 0, (unsigned long) (timeout * 1000.0), &numfds);
 	if (CURLM_OK != error) {
 		SAVE_CURLM_ERROR(mh, error);
 		RETURN_LONG(-1);

Original file line number	Diff line number	Diff line change
`@@ -233,7 +233,7 @@ PHP_FUNCTION(curl_multi_select)`
`233`	`233`	`}`
`234`	`234`
`235`	`235`	`#if LIBCURL_VERSION_NUM >= 0x071c00 /* Available since 7.28.0 */`
`236`		`- error = curl_multi_wait(mh->multi, NULL, 0, (unsigned long) timeout * 1000.0, &numfds);`
	`236`	`+ error = curl_multi_wait(mh->multi, NULL, 0, (unsigned long) (timeout * 1000.0), &numfds);`
`237`	`237`	`if (CURLM_OK != error) {`
`238`	`238`	`SAVE_CURLM_ERROR(mh, error);`
`239`	`239`	`RETURN_LONG(-1);`