Convert SPL illegal offset type into TypeError

Make this consistent with the corresponding engine behavior.
Also adjust the messages to match.

Author: nikic

ext/spl/spl_array.c

@@ -375,7 +375,7 @@ static zval *spl_array_get_dimension_ptr(int check_inherited, spl_array_object *
 		ZVAL_DEREF(offset);
 		goto try_again;
 	default:
-		zend_error(E_WARNING, "Illegal offset type");
+		zend_type_error("Illegal offset type");
 		return (type == BP_VAR_W || type == BP_VAR_RW) ?
 			&EG(error_zval) : &EG(uninitialized_zval);
 	}
@@ -499,7 +499,7 @@ static void spl_array_write_dimension_ex(int check_inherited, zend_object *objec
 			ZVAL_DEREF(offset);
 			goto try_again;
 		default:
-			zend_error(E_WARNING, "Illegal offset type");
+			zend_type_error("Illegal offset type");
 			zval_ptr_dtor(value);
 			return;
 	}
@@ -585,7 +585,7 @@ static void spl_array_unset_dimension_ex(int check_inherited, zend_object *objec
 		ZVAL_DEREF(offset);
 		goto try_again;
 	default:
-		zend_error(E_WARNING, "Illegal offset type");
+		zend_type_error("Illegal offset type in unset");
 		return;
 	}
 } /* }}} */
@@ -661,7 +661,7 @@ static int spl_array_has_dimension_ex(int check_inherited, zend_object *object,
 				ZVAL_DEREF(offset);
 				goto try_again;
 			default:
-				zend_error(E_WARNING, "Illegal offset type");
+				zend_type_error("Illegal offset type in isset or empty");
 				return 0;
 		}
 

ext/spl/tests/ArrayObject_illegal_offset.phpt

@@ -0,0 +1,39 @@
+--TEST--
+ArrayObject illegal offset
+--FILE--
+<?php
+
+$ao = new ArrayObject([1, 2, 3]);
+try {
+    var_dump($ao[[]]);
+} catch (TypeError $e) {
+    echo $e->getMessage(), "\n";
+}
+try {
+    $ao[[]] = new stdClass;
+} catch (TypeError $e) {
+    echo $e->getMessage(), "\n";
+}
+try {
+    $ref =& $ao[[]];
+} catch (TypeError $e) {
+    echo $e->getMessage(), "\n";
+}
+try {
+    var_dump(isset($ao[[]]));
+} catch (TypeError $e) {
+    echo $e->getMessage(), "\n";
+}
+try {
+    unset($ao[[]]);
+} catch (TypeError $e) {
+    echo $e->getMessage(), "\n";
+}
+
+?>
+--EXPECT--
+Illegal offset type
+Illegal offset type
+Illegal offset type
+Illegal offset type in isset or empty
+Illegal offset type in unset