Use arc4random_buf on macOS

devnexen · nikic · commit 7a049cd6a4f8 · 2021-01-12T10:42:09.000+01:00
macOS uses an AES based arc4random_buf implementation since at least macOS 10.2. Closes GH-6591.
diff --git a/ext/standard/random.c b/ext/standard/random.c
@@ -94,7 +94,7 @@ PHPAPI int php_random_bytes(void *bytes, size_t size, zend_bool should_throw)
 		}
 		return FAILURE;
 	}
-#elif HAVE_DECL_ARC4RANDOM_BUF && ((defined(__OpenBSD__) && OpenBSD >= 201405) || (defined(__NetBSD__) && __NetBSD_Version__ >= 700000001))
+#elif HAVE_DECL_ARC4RANDOM_BUF && ((defined(__OpenBSD__) && OpenBSD >= 201405) || (defined(__NetBSD__) && __NetBSD_Version__ >= 700000001) || defined(__APPLE__))
 	arc4random_buf(bytes, size);
 #else
 	size_t read_bytes = 0;

Original file line number	Diff line number	Diff line change
`@@ -94,7 +94,7 @@ PHPAPI int php_random_bytes(void *bytes, size_t size, zend_bool should_throw)`
`94`	`94`	`}`
`95`	`95`	`return FAILURE;`
`96`	`96`	`}`
`97`		`-#elif HAVE_DECL_ARC4RANDOM_BUF && ((defined(__OpenBSD__) && OpenBSD >= 201405) \|\| (defined(__NetBSD__) && __NetBSD_Version__ >= 700000001))`
	`97`	`+#elif HAVE_DECL_ARC4RANDOM_BUF && ((defined(__OpenBSD__) && OpenBSD >= 201405) \|\| (defined(__NetBSD__) && __NetBSD_Version__ >= 700000001) \|\| defined(__APPLE__))`
`98`	`98`	`arc4random_buf(bytes, size);`
`99`	`99`	`#else`
`100`	`100`	`size_t read_bytes = 0;`