Fix -Wpointer-type-mismatch warning (GH-17453)

cmb69 · web-flow · commit 788128aec79d · 2025-01-13T13:04:19.000+01:00
`GetProcAddress()` returns a `FARPROC` (aka. `long long (*)()`) which
is not compatible with `void *` per the specs.  However, on Windows
they are, so we silence the warning with a cast.
diff --git a/ext/ffi/ffi.c b/ext/ffi/ffi.c
@@ -3052,7 +3052,7 @@ static void *dlsym_loaded(char *symbol)
 	return addr;
 }
 # undef DL_FETCH_SYMBOL
-# define DL_FETCH_SYMBOL(h, s) (h == NULL ? dlsym_loaded(s) : GetProcAddress(h, s))
+# define DL_FETCH_SYMBOL(h, s) (h == NULL ? dlsym_loaded(s) : (void*) GetProcAddress(h, s))
 #endif
 
 ZEND_METHOD(FFI, cdef) /* {{{ */

Original file line number	Diff line number	Diff line change
`@@ -3052,7 +3052,7 @@ static void dlsym_loaded(char symbol)`
`3052`	`3052`	`return addr;`
`3053`	`3053`	`}`
`3054`	`3054`	`# undef DL_FETCH_SYMBOL`
`3055`		`-# define DL_FETCH_SYMBOL(h, s) (h == NULL ? dlsym_loaded(s) : GetProcAddress(h, s))`
	`3055`	`+# define DL_FETCH_SYMBOL(h, s) (h == NULL ? dlsym_loaded(s) : (void*) GetProcAddress(h, s))`
`3056`	`3056`	`#endif`
`3057`	`3057`
`3058`	`3058`	`ZEND_METHOD(FFI, cdef) /* {{{ */`