ext/standard/crc32: Use zend_result return type and remove unused header

Girgias · Girgias · commit 775ca03eb8c5 · 2024-08-20T14:18:50.000+02:00
diff --git a/ext/standard/crc32.c b/ext/standard/crc32.c
@@ -15,7 +15,6 @@
 */
 
 #include "php.h"
-#include "basic_functions.h"
 #include "crc32.h"
 #include "crc32_x86.h"
 
@@ -129,7 +128,7 @@ PHPAPI uint32_t php_crc32_bulk_update(uint32_t crc, const char *p, size_t nr)
 	return crc;
 }
 
-PHPAPI int php_crc32_stream_bulk_update(uint32_t *crc, php_stream *fp, size_t nr)
+PHPAPI zend_result php_crc32_stream_bulk_update(uint32_t *crc, php_stream *fp, size_t nr)
 {
 	size_t handled = 0, n;
 	char buf[1024];
diff --git a/ext/standard/crc32.h b/ext/standard/crc32.h
@@ -29,7 +29,7 @@
 PHPAPI uint32_t php_crc32_bulk_update(uint32_t crc, const char *p, size_t nr);
 
 /* Return FAILURE if stream reading fail */
-PHPAPI int php_crc32_stream_bulk_update(uint32_t *crc, php_stream *fp, size_t nr);
+PHPAPI zend_result php_crc32_stream_bulk_update(uint32_t *crc, php_stream *fp, size_t nr);
 
 /* generated using the AUTODIN II polynomial
  *	x^32 + x^26 + x^23 + x^22 + x^16 +

Original file line number	Diff line number	Diff line change
`@@ -15,7 +15,6 @@`
`15`	`15`	`*/`
`16`	`16`
`17`	`17`	`#include "php.h"`
`18`		`-#include "basic_functions.h"`
`19`	`18`	`#include "crc32.h"`
`20`	`19`	`#include "crc32_x86.h"`
`21`	`20`
`@@ -129,7 +128,7 @@ PHPAPI uint32_t php_crc32_bulk_update(uint32_t crc, const char *p, size_t nr)`
`129`	`128`	`return crc;`
`130`	`129`	`}`
`131`	`130`
`132`		`-PHPAPI int php_crc32_stream_bulk_update(uint32_t crc, php_stream fp, size_t nr)`
	`131`	`+PHPAPI zend_result php_crc32_stream_bulk_update(uint32_t crc, php_stream fp, size_t nr)`
`133`	`132`	`{`
`134`	`133`	`size_t handled = 0, n;`
`135`	`134`	`char buf[1024];`