Skip to content

Commit 7699534

Browse files
authored
Remove php_xsl_create_object() (#12492)
1 parent 0e5d654 commit 7699534

File tree

3 files changed

+4
-36
lines changed

3 files changed

+4
-36
lines changed

UPGRADING.INTERNALS

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -48,6 +48,10 @@ PHP 8.4 INTERNALS UPGRADE NOTES
4848
should either be inlined and undefined behavior fixed or it should be
4949
replaced by a non-biased scaler.
5050

51+
c. ext/xsl
52+
- The function php_xsl_create_object() was removed as it was not used
53+
nor exported.
54+
5155
========================
5256
4. OpCode changes
5357
========================

ext/xsl/php_xsl.c

Lines changed: 0 additions & 35 deletions
Original file line numberDiff line numberDiff line change
@@ -169,41 +169,6 @@ void php_xsl_set_object(zval *wrapper, void *obj)
169169
}
170170
/* }}} */
171171

172-
/* {{{ php_xsl_create_object */
173-
void php_xsl_create_object(xsltStylesheetPtr obj, zval *wrapper_in, zval *return_value )
174-
{
175-
zval *wrapper;
176-
zend_class_entry *ce;
177-
178-
if (!obj) {
179-
wrapper = wrapper_in;
180-
ZVAL_NULL(wrapper);
181-
return;
182-
}
183-
184-
if ((wrapper = xsl_object_get_data((void *) obj))) {
185-
ZVAL_COPY(wrapper, wrapper_in);
186-
return;
187-
}
188-
189-
if (!wrapper_in) {
190-
wrapper = return_value;
191-
} else {
192-
wrapper = wrapper_in;
193-
}
194-
195-
196-
ce = xsl_xsltprocessor_class_entry;
197-
198-
if (!wrapper_in) {
199-
object_init_ex(wrapper, ce);
200-
}
201-
php_xsl_set_object(wrapper, (void *) obj);
202-
203-
return;
204-
}
205-
/* }}} */
206-
207172
/* {{{ PHP_MSHUTDOWN_FUNCTION */
208173
PHP_MSHUTDOWN_FUNCTION(xsl)
209174
{

ext/xsl/php_xsl.h

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -75,7 +75,6 @@ static inline xsl_object *php_xsl_fetch_object(zend_object *obj) {
7575

7676
void php_xsl_set_object(zval *wrapper, void *obj);
7777
void xsl_objects_free_storage(zend_object *object);
78-
void php_xsl_create_object(xsltStylesheetPtr obj, zval *wrapper_in, zval *return_value );
7978

8079
void xsl_ext_function_string_php(xmlXPathParserContextPtr ctxt, int nargs);
8180
void xsl_ext_function_object_php(xmlXPathParserContextPtr ctxt, int nargs);

0 commit comments

Comments
 (0)