Implement Dom $innerHTML property

Author: nielsdos

ext/dom/config.m4

@@ -32,7 +32,7 @@ if test "$PHP_DOM" != "no"; then
                             parentnode/tree.c parentnode/css_selectors.c \
                             processinginstruction.c cdatasection.c \
                             documentfragment.c domimplementation.c \
-                            element.c node.c characterdata.c \
+                            element.c node.c characterdata.c inner_html_mixin.c \
                             documenttype.c entity.c \
                             nodelist.c html_collection.c text.c comment.c \
                             entityreference.c \

ext/dom/config.w32

@@ -10,7 +10,7 @@ if (PHP_DOM == "yes") {
 		EXTENSION("dom", "php_dom.c attr.c document.c infra.c \
 			xml_document.c html_document.c xml_serializer.c html5_serializer.c html5_parser.c namespace_compat.c \
 			domexception.c processinginstruction.c \
-			cdatasection.c documentfragment.c domimplementation.c element.c \
+			cdatasection.c documentfragment.c domimplementation.c element.c  inner_html_mixin.c \
 			node.c characterdata.c documenttype.c \
 			entity.c nodelist.c html_collection.c text.c comment.c \
 			entityreference.c \

ext/dom/dom_properties.h

@@ -83,6 +83,8 @@ zend_result dom_element_class_name_write(dom_object *obj, zval *newval);
 zend_result dom_element_id_read(dom_object *obj, zval *retval);
 zend_result dom_element_id_write(dom_object *obj, zval *newval);
 zend_result dom_element_schema_type_info_read(dom_object *obj, zval *retval);
+zend_result dom_element_inner_html_read(dom_object *obj, zval *retval);
+zend_result dom_element_inner_html_write(dom_object *obj, zval *newval);
 
 /* entity properties */
 zend_result dom_entity_public_id_read(dom_object *obj, zval *retval);

ext/dom/html5_parser.c

@@ -99,6 +99,7 @@ static zend_always_inline xmlNodePtr lexbor_libxml2_bridge_new_text_node_fast(xm
 static lexbor_libxml2_bridge_status lexbor_libxml2_bridge_convert(
     lxb_dom_node_t *start_node,
     xmlDocPtr lxml_doc,
+    xmlNodePtr root,
     bool compact_text_nodes,
     bool create_default_ns,
     php_dom_libxml_ns_mapper *ns_mapper
@@ -114,7 +115,7 @@ static lexbor_libxml2_bridge_status lexbor_libxml2_bridge_convert(
     lexbor_array_obj_init(&work_list, WORK_LIST_INIT_SIZE, sizeof(work_list_item));
 
     for (lxb_dom_node_t *node = start_node; node != NULL; node = node->prev) {
-        lexbor_libxml2_bridge_work_list_item_push(&work_list, node, LXB_NS__UNDEF, (xmlNodePtr) lxml_doc, NULL);
+        lexbor_libxml2_bridge_work_list_item_push(&work_list, node, LXB_NS__UNDEF, root, NULL);
     }
 
     work_list_item *current_stack_item;
@@ -316,6 +317,7 @@ lexbor_libxml2_bridge_status lexbor_libxml2_bridge_convert_document(
     lexbor_libxml2_bridge_status status = lexbor_libxml2_bridge_convert(
         lxb_dom_interface_node(document)->last_child,
         lxml_doc,
+        (xmlNodePtr) lxml_doc,
         compact_text_nodes,
         create_default_ns,
         ns_mapper
@@ -328,6 +330,35 @@ lexbor_libxml2_bridge_status lexbor_libxml2_bridge_convert_document(
     return LEXBOR_LIBXML2_BRIDGE_STATUS_OK;
 }
 
+lexbor_libxml2_bridge_status lexbor_libxml2_bridge_convert_fragment(
+    lxb_dom_node_t *start_node,
+    xmlDocPtr lxml_doc,
+    xmlNodePtr *fragment_out,
+    bool compact_text_nodes,
+    bool create_default_ns,
+    php_dom_libxml_ns_mapper *ns_mapper
+)
+{
+    xmlNodePtr fragment = xmlNewDocFragment(lxml_doc);
+    if (UNEXPECTED(fragment == NULL)) {
+        return LEXBOR_LIBXML2_BRIDGE_STATUS_OOM;
+    }
+    lexbor_libxml2_bridge_status status = lexbor_libxml2_bridge_convert(
+        start_node,
+        lxml_doc,
+        fragment,
+        compact_text_nodes,
+        create_default_ns,
+        ns_mapper
+    );
+    if (status != LEXBOR_LIBXML2_BRIDGE_STATUS_OK) {
+        xmlFreeNode(fragment);
+        return status;
+    }
+    *fragment_out = fragment;
+    return LEXBOR_LIBXML2_BRIDGE_STATUS_OK;
+}
+
 void lexbor_libxml2_bridge_report_errors(
     const lexbor_libxml2_bridge_parse_context *ctx,
     lxb_html_parser_t *parser,
@@ -376,12 +407,22 @@ void lexbor_libxml2_bridge_report_errors(
     *error_index_offset_tree = index;
 }
 
+static php_libxml_quirks_mode dom_translate_quirks_mode(lxb_dom_document_cmode_t quirks_mode)
+{
+	switch (quirks_mode) {
+		case LXB_DOM_DOCUMENT_CMODE_NO_QUIRKS: return PHP_LIBXML_NO_QUIRKS;
+		case LXB_DOM_DOCUMENT_CMODE_LIMITED_QUIRKS: return PHP_LIBXML_LIMITED_QUIRKS;
+		case LXB_DOM_DOCUMENT_CMODE_QUIRKS: return PHP_LIBXML_QUIRKS;
+		EMPTY_SWITCH_DEFAULT_CASE();
+	}
+}
+
 void lexbor_libxml2_bridge_copy_observations(lxb_html_tree_t *tree, lexbor_libxml2_bridge_extracted_observations *observations)
 {
     observations->has_explicit_html_tag = tree->has_explicit_html_tag;
     observations->has_explicit_head_tag = tree->has_explicit_head_tag;
     observations->has_explicit_body_tag = tree->has_explicit_body_tag;
-    observations->quirks_mode = lxb_dom_interface_document(tree->document)->compat_mode == LXB_DOM_DOCUMENT_CMODE_QUIRKS;
+    observations->quirks_mode = dom_translate_quirks_mode(lxb_dom_interface_document(tree->document)->compat_mode);
 }
 
 #endif  /* HAVE_LIBXML && HAVE_DOM */

ext/dom/html5_parser.h

@@ -47,7 +47,7 @@ typedef struct _lexbor_libxml2_bridge_extracted_observations {
     bool has_explicit_html_tag;
     bool has_explicit_head_tag;
     bool has_explicit_body_tag;
-    bool quirks_mode;
+    php_libxml_quirks_mode quirks_mode;
 } lexbor_libxml2_bridge_extracted_observations;
 
 typedef struct _lexbor_libxml2_bridge_parse_context {
@@ -73,6 +73,14 @@ lexbor_libxml2_bridge_status lexbor_libxml2_bridge_convert_document(
     bool create_default_ns,
     php_dom_libxml_ns_mapper *ns_mapper
 );
+lexbor_libxml2_bridge_status lexbor_libxml2_bridge_convert_fragment(
+    lxb_dom_node_t *start_node,
+    xmlDocPtr lxml_doc,
+    xmlNodePtr *fragment_out,
+    bool compact_text_nodes,
+    bool create_default_ns,
+    php_dom_libxml_ns_mapper *ns_mapper
+);
 void lexbor_libxml2_bridge_report_errors(
     const lexbor_libxml2_bridge_parse_context *ctx,
     lxb_html_parser_t *parser,