Add $result_code parameter to shell_exec

Author: l-pt

ext/standard/basic_functions.stub.php

@@ -1005,7 +1005,7 @@ function escapeshellcmd(string $command): string {}
 function escapeshellarg(string $arg): string {}
 
 /** @refcount 1 */
-function shell_exec(string $command): string|false|null {}
+function shell_exec(string $command, int &$result_code = null): string|false|null {}
 
 #ifdef HAVE_NICE
 function proc_nice(int $priority): bool {}

ext/standard/basic_functions_arginfo.h

@@ -1166,6 +1166,7 @@ ZEND_END_ARG_INFO()
 
 ZEND_BEGIN_ARG_WITH_RETURN_TYPE_MASK_EX(arginfo_shell_exec, 0, 1, MAY_BE_STRING|MAY_BE_FALSE|MAY_BE_NULL)
 	ZEND_ARG_TYPE_INFO(0, command, IS_STRING, 0)
+	ZEND_ARG_INFO_WITH_DEFAULT_VALUE(1, result_code, "null")
 ZEND_END_ARG_INFO()
 
 #if defined(HAVE_NICE)

ext/standard/exec.c

@@ -515,11 +515,15 @@ PHP_FUNCTION(shell_exec)
 	FILE *in;
 	char *command;
 	size_t command_len;
+	zval *ret_code = NULL;
 	zend_string *ret;
 	php_stream *stream;
+	int ret_pclose;
 
-	ZEND_PARSE_PARAMETERS_START(1, 1)
+	ZEND_PARSE_PARAMETERS_START(1, 2)
 		Z_PARAM_STRING(command, command_len)
+		Z_PARAM_OPTIONAL
+		Z_PARAM_ZVAL(ret_code)
 	ZEND_PARSE_PARAMETERS_END();
 
 	if (!command_len) {
@@ -542,8 +546,11 @@ PHP_FUNCTION(shell_exec)
 
 	stream = php_stream_fopen_from_pipe(in, "rb");
 	ret = php_stream_copy_to_mem(stream, PHP_STREAM_COPY_ALL, 0);
-	php_stream_close(stream);
+	ret_pclose = php_stream_close(stream);
 
+	if (ret_code) {
+		ZEND_TRY_ASSIGN_REF_LONG(ret_code, ret_pclose);
+	}
 	if (ret && ZSTR_LEN(ret) > 0) {
 		RETVAL_STR(ret);
 	}