Skip to content

Commit 73f52dc

Browse files
committed
Remove custom free_obj handler in xmlwriter
At one point this served a purpose as it contained the cleanup code that now lives in dtor, but now it just calls the standard handler so we can just get rid of it.
1 parent a3ef48c commit 73f52dc

File tree

1 file changed

+0
-11
lines changed

1 file changed

+0
-11
lines changed

ext/xmlwriter/php_xmlwriter.c

Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -66,16 +66,6 @@ static void xmlwriter_object_dtor(zend_object *object)
6666
}
6767
/* }}} */
6868

69-
/* {{{ xmlwriter_object_free_storage */
70-
static void xmlwriter_object_free_storage(zend_object *object)
71-
{
72-
ze_xmlwriter_object *intern = php_xmlwriter_fetch_object(object);
73-
74-
zend_object_std_dtor(&intern->std);
75-
}
76-
/* }}} */
77-
78-
7969
/* {{{ xmlwriter_object_new */
8070
static zend_object *xmlwriter_object_new(zend_class_entry *class_type)
8171
{
@@ -1064,7 +1054,6 @@ static PHP_MINIT_FUNCTION(xmlwriter)
10641054
memcpy(&xmlwriter_object_handlers, &std_object_handlers, sizeof(zend_object_handlers));
10651055
xmlwriter_object_handlers.offset = XtOffsetOf(ze_xmlwriter_object, std);
10661056
xmlwriter_object_handlers.dtor_obj = xmlwriter_object_dtor;
1067-
xmlwriter_object_handlers.free_obj = xmlwriter_object_free_storage;
10681057
xmlwriter_object_handlers.clone_obj = NULL;
10691058
xmlwriter_class_entry_ce = register_class_XMLWriter();
10701059
xmlwriter_class_entry_ce->create_object = xmlwriter_object_new;

0 commit comments

Comments
 (0)