Skip to content

Commit 72ec23d

Browse files
lwhsunikic
authored andcommitted
Fix bug #75677: Drop fastcall attribute on variadic function
Fastcall generally doesn't make sense on variadic functions. For clang in particular this eliminates a "fastcall calling convention ignored on variadic function" warning.
1 parent 6b1a177 commit 72ec23d

File tree

3 files changed

+4
-2
lines changed

3 files changed

+4
-2
lines changed

NEWS

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,8 @@ PHP NEWS
2323
properties). (pmmaga)
2424
. Fixed bug #63911 (identical trait methods raise errors during composition).
2525
(pmmaga)
26+
. Fixed bug #75677 (Clang ignores fastcall calling convention on variadic
27+
function). (Li-Wen Hsu)
2628

2729
- BCMath:
2830
. Fixed bug #66364 (BCMath bcmul ignores scale parameter). (cmb)

Zend/zend_hash.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1615,7 +1615,7 @@ ZEND_API void ZEND_FASTCALL zend_hash_apply_with_argument(HashTable *ht, apply_f
16151615
}
16161616

16171617

1618-
ZEND_API void ZEND_FASTCALL zend_hash_apply_with_arguments(HashTable *ht, apply_func_args_t apply_func, int num_args, ...)
1618+
ZEND_API void zend_hash_apply_with_arguments(HashTable *ht, apply_func_args_t apply_func, int num_args, ...)
16191619
{
16201620
uint32_t idx;
16211621
Bucket *p;

Zend/zend_hash.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -154,7 +154,7 @@ ZEND_API void ZEND_FASTCALL zend_hash_graceful_destroy(HashTable *ht);
154154
ZEND_API void ZEND_FASTCALL zend_hash_graceful_reverse_destroy(HashTable *ht);
155155
ZEND_API void ZEND_FASTCALL zend_hash_apply(HashTable *ht, apply_func_t apply_func);
156156
ZEND_API void ZEND_FASTCALL zend_hash_apply_with_argument(HashTable *ht, apply_func_arg_t apply_func, void *);
157-
ZEND_API void ZEND_FASTCALL zend_hash_apply_with_arguments(HashTable *ht, apply_func_args_t apply_func, int, ...);
157+
ZEND_API void zend_hash_apply_with_arguments(HashTable *ht, apply_func_args_t apply_func, int, ...);
158158

159159
/* This function should be used with special care (in other words,
160160
* it should usually not be used). When used with the ZEND_HASH_APPLY_STOP

0 commit comments

Comments
 (0)