Skip to content

Commit 6f81e95

Browse files
committed
check length first, prevent out-of-bounds read
1 parent 5154a48 commit 6f81e95

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

ext/session/session.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2942,7 +2942,7 @@ static int php_session_rfc1867_callback(unsigned int event, void *event_data, vo
29422942
if (name_len == progress->sname_len && memcmp(data->name, PS(session_name), name_len) == 0) {
29432943
zval_dtor(&progress->sid);
29442944
ZVAL_STRINGL(&progress->sid, (*data->value), value_len);
2945-
} else if (memcmp(data->name, PS(rfc1867_name), name_len + 1) == 0) {
2945+
} else if (name_len == strlen(PS(rfc1867_name)) && memcmp(data->name, PS(rfc1867_name), name_len + 1) == 0) {
29462946
smart_str_free(&progress->key);
29472947
smart_str_appends(&progress->key, PS(rfc1867_prefix));
29482948
smart_str_appendl(&progress->key, *data->value, value_len);

0 commit comments

Comments
 (0)