Skip to content

Commit 6ed4e86

Browse files
committed
Update libmysqlclient versions
5.7 is EOL, 8.2 was released. Also remove mysqli from these builds as PHP-8.1 goes into security mode, after which nightly is not really actively supported anymore.
1 parent 2895d4a commit 6ed4e86

File tree

2 files changed

+66
-18
lines changed

2 files changed

+66
-18
lines changed

.github/workflows/nightly.yml

Lines changed: 9 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -697,7 +697,7 @@ jobs:
697697
matrix:
698698
branch: ${{ fromJson(needs.GENERATE_MATRIX.outputs.branches) }}
699699
exclude:
700-
- branch: { name: 'PHP-80', ref: 'PHP-8.0' }
700+
- branch: { name: 'PHP-80', ref: 'PHP-8.0', major: 8, minor: 0 }
701701
name: "${{ matrix.branch.name }}_LIBMYSQLCLIENT"
702702
runs-on: ubuntu-${{ matrix.branch.version.minor >= 3 && '22.04' || '20.04' }}
703703
steps:
@@ -715,30 +715,25 @@ jobs:
715715
mysql -uroot -proot -e "CREATE DATABASE IF NOT EXISTS test"
716716
# Ensure local_infile tests can run.
717717
mysql -uroot -proot -e "SET GLOBAL local_infile = true"
718-
# Does not support caching_sha2_auth :(
719-
# - name: Build mysql-5.6
720-
# uses: ./.github/actions/build-libmysqlclient
721-
# with:
722-
# libmysql: mysql-5.6.49-linux-glibc2.12-x86_64.tar.gz
723-
# - name: Test mysql-5.6
724-
# uses: ./.github/actions/test-libmysqlclient
725-
- name: Build mysql-5.7
718+
- name: Build mysql-8.0
726719
uses: ./.github/actions/build-libmysqlclient
727720
with:
728-
libmysql: mysql-5.7.44-linux-glibc2.12-x86_64.tar.gz
721+
# FIXME: There are new warnings
722+
# configurationParameters: --enable-werror
723+
libmysql: mysql-8.0.35-linux-glibc2.28-x86_64.tar.xz
729724
withMysqli: ${{ matrix.branch.ref == 'PHP-8.1' }}
730-
- name: Test mysql-5.7
725+
- name: Test mysql-8.0
731726
uses: ./.github/actions/test-libmysqlclient
732727
with:
733728
withMysqli: ${{ matrix.branch.ref == 'PHP-8.1' }}
734-
- name: Build mysql-8.0
729+
- name: Build mysql-8.2
735730
uses: ./.github/actions/build-libmysqlclient
736731
with:
737732
# FIXME: There are new warnings
738733
# configurationParameters: --enable-werror
739-
libmysql: mysql-8.0.35-linux-glibc2.12-x86_64.tar.xz
734+
libmysql: mysql-8.2.0-linux-glibc2.28-x86_64.tar.xz
740735
withMysqli: ${{ matrix.branch.ref == 'PHP-8.1' }}
741-
- name: Test mysql-8.0
736+
- name: Test mysql-8.2
742737
uses: ./.github/actions/test-libmysqlclient
743738
with:
744739
withMysqli: ${{ matrix.branch.ref == 'PHP-8.1' }}

.github/workflows/push.yml

Lines changed: 57 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -40,11 +40,12 @@ permissions:
4040
concurrency:
4141
group: ${{ github.workflow }}-${{ github.event.pull_request.url || github.run_id }}
4242
cancel-in-progress: true
43-
env:
44-
CC: ccache gcc
45-
CXX: ccache g++
43+
# env:
44+
# CC: ccache gcc
45+
# CXX: ccache g++
4646
jobs:
4747
LINUX_X64:
48+
if: false
4849
services:
4950
mysql:
5051
image: mysql:8
@@ -141,6 +142,7 @@ jobs:
141142
if: ${{ !matrix.asan }}
142143
uses: ./.github/actions/verify-generated-files
143144
MACOS_DEBUG_NTS:
145+
if: false
144146
runs-on: macos-12
145147
steps:
146148
- name: git checkout
@@ -173,6 +175,7 @@ jobs:
173175
- name: Verify generated files are up to date
174176
uses: ./.github/actions/verify-generated-files
175177
WINDOWS:
178+
if: false
176179
name: WINDOWS_X64_ZTS
177180
runs-on: windows-2019
178181
env:
@@ -199,7 +202,8 @@ jobs:
199202
run: .github/scripts/windows/test.bat
200203
BENCHMARKING:
201204
name: BENCHMARKING
202-
if: github.repository_owner == 'php' || github.event_name == 'pull_request'
205+
if: false
206+
# if: github.repository_owner == 'php' || github.event_name == 'pull_request'
203207
runs-on: ubuntu-22.04
204208
steps:
205209
- name: git checkout
@@ -298,3 +302,52 @@ jobs:
298302
name: profiles
299303
path: ${{ github.workspace }}/benchmark/profiles
300304
retention-days: 30
305+
LIBMYSQLCLIENT:
306+
strategy:
307+
fail-fast: false
308+
matrix:
309+
include:
310+
- branch: { name: 'MASTER', ref: 'master', version: { major: 8, minor: 4 } }
311+
- branch: { name: 'PHP-83', ref: 'PHP-8.3', version: { major: 8, minor: 3 } }
312+
- branch: { name: 'PHP-82', ref: 'PHP-8.2', version: { major: 8, minor: 2 } }
313+
name: "${{ matrix.branch.name }}_LIBMYSQLCLIENT"
314+
runs-on: ubuntu-${{ matrix.branch.version.minor >= 3 && '22.04' || '20.04' }}
315+
steps:
316+
- name: git checkout
317+
uses: actions/checkout@v4
318+
with:
319+
ref: ${{ matrix.branch.ref }}
320+
- name: apt
321+
run: |
322+
sudo apt-get update -y | true
323+
sudo apt install bison re2c
324+
- name: Setup
325+
run: |
326+
sudo service mysql start
327+
mysql -uroot -proot -e "CREATE DATABASE IF NOT EXISTS test"
328+
# Ensure local_infile tests can run.
329+
mysql -uroot -proot -e "SET GLOBAL local_infile = true"
330+
- name: Build mysql-8.0
331+
uses: ./.github/actions/build-libmysqlclient
332+
with:
333+
# FIXME: There are new warnings
334+
# configurationParameters: --enable-werror
335+
libmysql: mysql-8.0.35-linux-glibc2.28-x86_64.tar.xz
336+
withMysqli: ${{ matrix.branch.ref == 'PHP-8.1' }}
337+
- name: Test mysql-8.0
338+
uses: ./.github/actions/test-libmysqlclient
339+
with:
340+
withMysqli: ${{ matrix.branch.ref == 'PHP-8.1' }}
341+
- name: Build mysql-8.2
342+
uses: ./.github/actions/build-libmysqlclient
343+
with:
344+
# FIXME: There are new warnings
345+
# configurationParameters: --enable-werror
346+
libmysql: mysql-8.2.0-linux-glibc2.28-x86_64.tar.xz
347+
withMysqli: ${{ matrix.branch.ref == 'PHP-8.1' }}
348+
- name: Test mysql-8.2
349+
uses: ./.github/actions/test-libmysqlclient
350+
with:
351+
withMysqli: ${{ matrix.branch.ref == 'PHP-8.1' }}
352+
- name: Verify generated files are up to date
353+
uses: ./.github/actions/verify-generated-files

0 commit comments

Comments
 (0)