Use APPLY_STOP in pcre_clean_cache()

iluuu1994 · iluuu1994 · commit 6cb31fea5833 · 2024-09-11T14:20:00.000+02:00
Once num_clean has reached 0, we never remove any more elements anyway.
diff --git a/ext/pcre/php_pcre.c b/ext/pcre/php_pcre.c
@@ -524,8 +524,10 @@ static int pcre_clean_cache(zval *data, void *arg)
 	if (*num_clean > 0 && !pce->refcount) {
 		(*num_clean)--;
 		return ZEND_HASH_APPLY_REMOVE;
-	} else {
+	} else if (*num_clean > 0) {
 		return ZEND_HASH_APPLY_KEEP;
+	} else {
+		return ZEND_HASH_APPLY_STOP;
 	}
 }
 /* }}} */

Original file line number	Diff line number	Diff line change
`@@ -524,8 +524,10 @@ static int pcre_clean_cache(zval data, void arg)`
`524`	`524`	`if (*num_clean > 0 && !pce->refcount) {`
`525`	`525`	`(*num_clean)--;`
`526`	`526`	`return ZEND_HASH_APPLY_REMOVE;`
`527`		`- } else {`
	`527`	`+ } else if (*num_clean > 0) {`
`528`	`528`	`return ZEND_HASH_APPLY_KEEP;`
	`529`	`+ } else {`
	`530`	`+ return ZEND_HASH_APPLY_STOP;`
`529`	`531`	`}`
`530`	`532`	`}`
`531`	`533`	`/* }}} */`