Fixed bug #78391

nikic · nikic · commit 699b465da20f · 2019-08-09T15:03:40.000+02:00
diff --git a/NEWS b/NEWS
@@ -6,6 +6,10 @@ PHP                                                                        NEWS
   . Fixed bug #78383 (Casting a DateTime to array no longer returns its
     properties). (Nikita)
 
+- OpenSSL:
+  . Fixed bug #78391 (Assertion failure in openssl_random_pseudo_bytes).
+    (Nikita)
+
 08 Aug 2019, PHP 7.4.0beta2
 
 - Core:
diff --git a/ext/openssl/openssl.c b/ext/openssl/openssl.c
@@ -6974,7 +6974,7 @@ PHP_FUNCTION(openssl_random_pseudo_bytes)
 	zend_long buffer_length;
 	zval *zstrong_result_returned = NULL;
 
-	if (zend_parse_parameters(ZEND_NUM_ARGS(), "l|z/", &buffer_length, &zstrong_result_returned) == FAILURE) {
+	if (zend_parse_parameters(ZEND_NUM_ARGS(), "l|z", &buffer_length, &zstrong_result_returned) == FAILURE) {
 		return;
 	}
 
diff --git a/ext/openssl/tests/bug78391.phpt b/ext/openssl/tests/bug78391.phpt
@@ -0,0 +1,13 @@
+--TEST--
+Bug #78391: Assertion failure in openssl_random_pseudo_bytes
+--FILE--
+<?php
+
+$isStrongCrypto = false;
+var_dump(strlen(openssl_random_pseudo_bytes(16, $isStrongCrypto)));
+var_dump($isStrongCrypto);
+
+?>
+--EXPECT--
+int(16)
+bool(true)

Original file line number	Diff line number	Diff line change
`@@ -6974,7 +6974,7 @@ PHP_FUNCTION(openssl_random_pseudo_bytes)`
`6974`	`6974`	`zend_long buffer_length;`
`6975`	`6975`	`zval *zstrong_result_returned = NULL;`
`6976`	`6976`
`6977`		`- if (zend_parse_parameters(ZEND_NUM_ARGS(), "l\|z/", &buffer_length, &zstrong_result_returned) == FAILURE) {`
	`6977`	`+ if (zend_parse_parameters(ZEND_NUM_ARGS(), "l\|z", &buffer_length, &zstrong_result_returned) == FAILURE) {`
`6978`	`6978`	`return;`
`6979`	`6979`	`}`
`6980`	`6980`