Skip to content

Commit 6969797

Browse files
committed
Make invalid types in intersection more robust
1 parent bdbe85c commit 6969797

File tree

2 files changed

+9
-5
lines changed

2 files changed

+9
-5
lines changed

Zend/tests/type_declarations/intersection_types/invalid_types/invalid_iterable_type.phpt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,4 +7,4 @@ function foo(): iterable&Iterator {}
77

88
?>
99
--EXPECTF--
10-
Fatal error: Type iterable cannot be part of an intersection type in %s on line %d
10+
Fatal error: Type Traversable|array cannot be part of an intersection type in %s on line %d

Zend/zend_compile.c

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -6275,11 +6275,15 @@ static zend_type zend_compile_typename(
62756275
zend_ast *type_ast = list->child[i];
62766276
zend_type single_type = zend_compile_single_typename(type_ast);
62776277

6278-
/* An intersection of standard types cannot exist so invalidate it */
6279-
/* Check for iterable early */
6280-
if (ZEND_TYPE_IS_ITERABLE_FALLBACK(single_type)) {
6281-
zend_error_noreturn(E_COMPILE_ERROR, "Type iterable cannot be part of an intersection type");
6278+
/* An intersection of union types cannot exist so invalidate it
6279+
* Currently only can happen with iterable getting canonicalized to Traversable|array */
6280+
if (ZEND_TYPE_IS_UNION(single_type)) {
6281+
zend_string *standard_type_str = zend_type_to_string(single_type);
6282+
zend_error_noreturn(E_COMPILE_ERROR,
6283+
"Type %s cannot be part of an intersection type", ZSTR_VAL(standard_type_str));
6284+
zend_string_release_ex(standard_type_str, false);
62826285
}
6286+
/* An intersection of standard types cannot exist so invalidate it */
62836287
if (ZEND_TYPE_IS_ONLY_MASK(single_type)) {
62846288
zend_string *standard_type_str = zend_type_to_string(single_type);
62856289
zend_error_noreturn(E_COMPILE_ERROR,

0 commit comments

Comments
 (0)