Added explicit checks for when needle is longer than haystack

Author: wkhudgins92

ext/standard/string.c

@@ -2312,6 +2312,10 @@ PHP_FUNCTION(str_begins) {
         Z_PARAM_STR(needle)
     ZEND_PARSE_PARAMETERS_END();
 
+    if (needle->len > haystack->len) {
+        RETURN_BOOL(0);
+    }
+
 	for (i = 0; i < needle->len; i++) 
 		if (haystack->val[i] != needle->val[i]) 
 			RETURN_BOOL(0);
@@ -2329,6 +2333,10 @@ PHP_FUNCTION(str_ibegins) {
         Z_PARAM_STR(needle)
     ZEND_PARSE_PARAMETERS_END();
 
+    if (needle->len > haystack->len) {
+        RETURN_BOOL(0);
+    }
+
 	for (i = 0; i < needle->len; i++) 
 		if (tolower(haystack->val[i]) != tolower(needle->val[i])) 
 			RETURN_BOOL(0); 
@@ -2345,6 +2353,10 @@ PHP_FUNCTION(str_ends) {
         Z_PARAM_STR(haystack)
         Z_PARAM_STR(needle)
     ZEND_PARSE_PARAMETERS_END();
+    
+    if (needle->len > haystack->len) {
+        RETURN_BOOL(0);
+    }
 
 	for (i = haystack->len - 1, j = needle->len - 1; j >= 0; i--, j--) 
 		if (haystack->val[i] != needle->val[j]) 
@@ -2363,6 +2375,10 @@ PHP_FUNCTION(str_iends) {
         Z_PARAM_STR(needle)
     ZEND_PARSE_PARAMETERS_END();
 
+    if (needle->len > haystack->len) {
+        RETURN_BOOL(0);
+    }
+
 	for (i = haystack->len - 1, j = needle->len - 1; j >= 0; i--, j--) 
 		if (tolower(haystack->val[i]) != tolower(needle->val[j])) 	
 			RETURN_BOOL(0);

ext/standard/tests/strings/str_ends.phpt

@@ -9,8 +9,10 @@ $testStr = "beginningMiddleEnd";
 var_dump(str_ends($testStr, "End"));
 var_dump(str_ends($testStr, "end"));
 var_dump(str_ends($testStr, "en"));
+var_dump(str_ends($testStr, $testStr."a"));
 ?>
 --EXPECT--
 bool(true)
 bool(false)
 bool(false)
+bool(false)

ext/standard/tests/strings/str_iends.phpt

@@ -9,8 +9,10 @@ $testStr = "beginningMiddleEnd";
 var_dump(str_iends($testStr, "End"));
 var_dump(str_iends($testStr, "end"));
 var_dump(str_iends($testStr, "en"));
+var_dump(str_iends($testStr, $testStr."a"));
 ?>
 --EXPECT--
 bool(true)
 bool(true)
 bool(false)
+bool(false)