Fix invalid efree in browscap

nikic · nikic · commit 64de5bc22458 · 2018-12-23T20:20:04.000+01:00
Related to bug #77338.
diff --git a/ext/standard/browscap.c b/ext/standard/browscap.c
@@ -713,7 +713,7 @@ PHP_FUNCTION(get_browser)
 			found_entry = zend_hash_str_find_ptr(bdata->htab,
 				DEFAULT_SECTION_NAME, sizeof(DEFAULT_SECTION_NAME)-1);
 			if (found_entry == NULL) {
-				efree(lookup_browser_name);
+				zend_string_release(lookup_browser_name);
 				RETURN_FALSE;
 			}
 		}
diff --git a/ext/standard/tests/misc/browscap_no_default.ini b/ext/standard/tests/misc/browscap_no_default.ini
@@ -0,0 +1,2 @@
+[Firefox]
+Browser="Firefox"
diff --git a/ext/standard/tests/misc/get_browser_no_default.phpt b/ext/standard/tests/misc/get_browser_no_default.phpt
@@ -0,0 +1,12 @@
+--TEST--
+get_browser() without a default
+--INI--
+browscap={PWD}/browscap_no_default.ini
+--FILE--
+<?php
+
+var_dump(get_browser(""));
+
+?>
+--EXPECT--
+bool(false)

Original file line number	Diff line number	Diff line change
`@@ -713,7 +713,7 @@ PHP_FUNCTION(get_browser)`
`713`	`713`	`found_entry = zend_hash_str_find_ptr(bdata->htab,`
`714`	`714`	`DEFAULT_SECTION_NAME, sizeof(DEFAULT_SECTION_NAME)-1);`
`715`	`715`	`if (found_entry == NULL) {`
`716`		`- efree(lookup_browser_name);`
	`716`	`+ zend_string_release(lookup_browser_name);`
`717`	`717`	`RETURN_FALSE;`
`718`	`718`	`}`
`719`	`719`	`}`