Do not warn but enable legacy cnbversion test

Author: Girgias

Zend/zend_API.c

@@ -2865,8 +2865,10 @@ ZEND_API zend_result zend_register_functions(zend_class_entry *scope, const zend
 					}
 				}
 				if (ZEND_TYPE_IS_ITERABLE_FALLBACK(new_arg_info[i].type)) {
+					/* Do not warn?
 					zend_error(E_CORE_WARNING, "iterable type is now a compile time alias for array|Traversable,"
 						" regenerate the argument info via the php-src gen_stub build script");
+					*/
 					zend_type legacy_iterable = ZEND_TYPE_INIT_CLASS_CONST_MASK(ZSTR_KNOWN(ZEND_STR_TRAVERSABLE),
 						(new_arg_info[i].type.type_mask|_ZEND_TYPE_UNION_BIT|MAY_BE_ARRAY));
 					memcpy(&new_arg_info[i].type, &legacy_iterable, sizeof(zend_type));

ext/zend_test/test.c

@@ -615,8 +615,7 @@ PHP_MINIT_FUNCTION(zend_test)
 	zend_test_string_enum = register_class_ZendTestStringEnum();
 	zend_test_int_enum = register_class_ZendTestIntEnum();
 
-	/* Register legacy iterable function, this generates E_CORE_WARNING on startup */
-	//zend_register_functions(NULL, ext_function_legacy, NULL, EG(current_module)->type);
+	zend_register_functions(NULL, ext_function_legacy, NULL, EG(current_module)->type);
 
 	// Loading via dl() not supported with the observer API
 	if (type != MODULE_TEMPORARY) {

ext/zend_test/tests/zend_legacy_iterable.phpt

@@ -1,10 +1,5 @@
 --TEST--
 Test that legacy IS_ITERABLE arg info type generates a notice
---SKIPIF--
-<?php
-if (true) {
-    die('skip only if testing startup warnings contaminate all test');
-}
 --EXTENSIONS--
 zend_test
 --FILE--
@@ -22,11 +17,6 @@ var_dump(zend_iterable_legacy(gen(), gen()));
 ?>
 ==DONE==
 --EXPECT--
-Warning: iterable type is now a compile time alias for array|Traversable, regenerate the argument info via the php-src gen_stub build script in Unknown on line 0
-
-Warning: iterable type is now a compile time alias for array|Traversable, regenerate the argument info via the php-src gen_stub build script in Unknown on line 0
-
-Warning: iterable type is now a compile time alias for array|Traversable, regenerate the argument info via the php-src gen_stub build script in Unknown on line 0
 array(0) {
 }
 array(0) {