Remove MYSQLI_SET_CHARSET_DIR (#14724)

kamil-tekiela · web-flow · commit 62a3bbd0e384 · 2024-06-29T22:21:03.000+02:00
diff --git a/UPGRADING b/UPGRADING
@@ -704,6 +704,10 @@ PHP 8.4 UPGRADE NOTES
 - MBString:
   . Unicode data tables have been updated to Unicode 15.1.
 
+- mysqli:
+  . The unused and undocumented constant MYSQLI_SET_CHARSET_DIR
+    has been removed.
+
 - OpenSSL:
   . The OpenSSL extension now requires at least OpenSSL 1.1.1.
 
diff --git a/ext/mysqli/mysqli.stub.php b/ext/mysqli/mysqli.stub.php
@@ -436,11 +436,6 @@
  * @cvalue MYSQL_SET_CHARSET_NAME
  */
 const MYSQLI_SET_CHARSET_NAME = UNKNOWN;
-/**
- * @var int
- * @cvalue MYSQL_SET_CHARSET_DIR
- */
-const MYSQLI_SET_CHARSET_DIR = UNKNOWN;
 
 /* bind support */
 /**
diff --git a/ext/mysqli/mysqli_arginfo.h b/ext/mysqli/mysqli_arginfo.h
diff --git a/ext/mysqli/tests/mysqli_constants.phpt b/ext/mysqli/tests/mysqli_constants.phpt
@@ -82,7 +82,6 @@ $expected_constants = array(
     "MYSQLI_REPORT_ERROR"				=> true,
     "MYSQLI_REPORT_OFF"					=> true,
     "MYSQLI_SET_CHARSET_NAME"			=> true,
-    "MYSQLI_SET_CHARSET_DIR"			=> true,
     "MYSQLI_REFRESH_GRANT"				=> true,
     "MYSQLI_REFRESH_LOG"				=> true,
     "MYSQLI_REFRESH_TABLES"				=> true,
