Fix jit with incompatible float to long for isset

Girgias · Girgias · commit 619ad88b716b · 2021-04-17T17:03:26.000+01:00
diff --git a/ext/opcache/jit/zend_jit_helpers.c b/ext/opcache/jit/zend_jit_helpers.c
@@ -1272,7 +1272,7 @@ static int ZEND_FASTCALL zend_jit_isset_dim_helper(zval *container, zval *offset
 			if (Z_TYPE_P(offset) < IS_STRING /* simple scalar types */
 					|| (Z_TYPE_P(offset) == IS_STRING /* or numeric string */
 						&& IS_LONG == is_numeric_string(Z_STRVAL_P(offset), Z_STRLEN_P(offset), NULL, NULL, false))) {
-				lval = zval_get_long(offset);
+				lval = zval_get_long_ex(offset, /* is_strict */ true);
 				goto isset_str_offset;
 			}
 		}

Original file line number	Diff line number	Diff line change
`@@ -1272,7 +1272,7 @@ static int ZEND_FASTCALL zend_jit_isset_dim_helper(zval container, zval offset`
`1272`	`1272`	`if (Z_TYPE_P(offset) < IS_STRING /* simple scalar types */`
`1273`	`1273`	`\|\| (Z_TYPE_P(offset) == IS_STRING /* or numeric string */`
`1274`	`1274`	`&& IS_LONG == is_numeric_string(Z_STRVAL_P(offset), Z_STRLEN_P(offset), NULL, NULL, false))) {`
`1275`		`- lval = zval_get_long(offset);`
	`1275`	`+ lval = zval_get_long_ex(offset, /* is_strict */ true);`
`1276`	`1276`	`goto isset_str_offset;`
`1277`	`1277`	`}`
`1278`	`1278`	`}`