Skip to content

Commit 6119d4c

Browse files
committed
Merge branch 'PHP-7.2' into PHP-7.3
* PHP-7.2: Note that PECL install now works on PHP 7.3 Don't skip with 18c DB
2 parents e355e55 + 43adf3d commit 6119d4c

File tree

2 files changed

+6
-5
lines changed

2 files changed

+6
-5
lines changed

ext/oci8/package.xml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -67,6 +67,7 @@ Interoperability Support" (ID 207303.1) for details.
6767
<notes>
6868
This version is for PHP 7 only.
6969
Fixed bug #76804 (oci_pconnect with OCI_CRED_EXT not working). (KoenigsKind)
70+
Fixed installation on 7.3.
7071
</notes>
7172
<contents>
7273
<dir name="/">

ext/oci8/tests/driver_name.phpt

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -8,9 +8,9 @@ if (strcasecmp($user, "system") && strcasecmp($user, "sys")) die("skip needs to
88
if ($test_drcp) die("skip as Output might vary with DRCP");
99

1010
preg_match('/.*Release ([[:digit:]]+)\.([[:digit:]]+)\.([[:digit:]]+)\.([[:digit:]]+)\.([[:digit:]]+)*/', oci_server_version($c), $matches);
11-
if (!(isset($matches[0]) &&
11+
if (!(isset($matches[0]) && ($matches[1] > 12 ||
1212
($matches[1] == 12 && $matches[2] == 1 && $matches[3] >= 0
13-
&& $matches[4] >= 2) || ($matches[1] == 12 && $matches[2] > 1))) {
13+
&& $matches[4] >= 2) || ($matches[1] == 12 && $matches[2] > 1)))) {
1414
die("skip test expected to work only with Oracle 12.1.0.2 database or its later patchsets");
1515
}
1616

@@ -57,11 +57,11 @@ function get_attr($conn)
5757
?>
5858
--EXPECT--
5959
**Test 1.1 - Default values for the attribute **************
60-
The value of DRIVER_NAME is PHP OCI8 : 2.1.8
60+
The value of DRIVER_NAME is PHP OCI8 : 2.1.9
6161

6262
***Test 1.2 - Get the values from different connections **************
6363
Testing with oci_pconnect()
64-
The value of DRIVER_NAME is PHP OCI8 : 2.1.8
64+
The value of DRIVER_NAME is PHP OCI8 : 2.1.9
6565
Testing with oci_new_connect()
66-
The value of DRIVER_NAME is PHP OCI8 : 2.1.8
66+
The value of DRIVER_NAME is PHP OCI8 : 2.1.9
6767
Done

0 commit comments

Comments
 (0)