Fixed bug #68638 pg_update() fails to store infinite values

William Felipe Welter · William Felipe Welter · commit 60d5cdf13799 · 2015-02-09T20:35:18.000-02:00
Check if value is "infinity" with strcasestr() to add quotes
diff --git a/ext/pgsql/pgsql.c b/ext/pgsql/pgsql.c
@@ -5591,15 +5591,13 @@ PHP_PGSQL_API int php_pgsql_convert(PGconn *pg_link, const char *table_name, con
 						else {
 							/* FIXME: better regex must be used */
 							if (php_pgsql_convert_match(Z_STRVAL_PP(val), Z_STRLEN_PP(val), "^([+-]{0,1}[0-9]+)|([+-]{0,1}[0-9]*[\\.][0-9]+)|([+-]{0,1}[0-9]+[\\.][0-9]*)|([+-]{0,1}(inf)(inity){0,1})$", 1 TSRMLS_CC) == FAILURE) {
-								err = 1;
+									err = 1;
 							}
 							else {
-
 								ZVAL_STRING(new_val, Z_STRVAL_PP(val), 1);
-								if(php_pgsql_convert_match(Z_STRVAL_PP(val), Z_STRLEN_PP(val), "^([+-]{0,1}(inf)(inity){0,1})$", 1 TSRMLS_CC) == SUCCESS) {
+								if(strcasestr(Z_STRVAL_PP(val),"inf")!=0){
 									php_pgsql_add_quotes(new_val, 1 TSRMLS_CC);
 								}
-
 							}
 						}
 						break;

Original file line number	Diff line number	Diff line change
`@@ -5591,15 +5591,13 @@ PHP_PGSQL_API int php_pgsql_convert(PGconn pg_link, const char table_name, con`
`5591`	`5591`	`else {`
`5592`	`5592`	`/* FIXME: better regex must be used */`
`5593`	`5593`	`if (php_pgsql_convert_match(Z_STRVAL_PP(val), Z_STRLEN_PP(val), "^([+-]{0,1}[0-9]+)\|([+-]{0,1}[0-9][\\.][0-9]+)\|([+-]{0,1}[0-9]+[\\.][0-9])\|([+-]{0,1}(inf)(inity){0,1})$", 1 TSRMLS_CC) == FAILURE) {`
`5594`		`- err = 1;`
	`5594`	`+ err = 1;`
`5595`	`5595`	`}`
`5596`	`5596`	`else {`
`5597`		`-`
`5598`	`5597`	`ZVAL_STRING(new_val, Z_STRVAL_PP(val), 1);`
`5599`		`- if(php_pgsql_convert_match(Z_STRVAL_PP(val), Z_STRLEN_PP(val), "^([+-]{0,1}(inf)(inity){0,1})$", 1 TSRMLS_CC) == SUCCESS) {`
	`5598`	`+ if(strcasestr(Z_STRVAL_PP(val),"inf")!=0){`
`5600`	`5599`	`php_pgsql_add_quotes(new_val, 1 TSRMLS_CC);`
`5601`	`5600`	`}`
`5602`		`-`
`5603`	`5601`	`}`
`5604`	`5602`	`}`
`5605`	`5603`	`break;`