Skip to content

Commit 60717fc

Browse files
committed
Merge branch 'PHP-8.0' into PHP-8.1
* PHP-8.0: Fix #74604: Out of bounds in php_pcre_replace_impl
2 parents b914122 + 816aa20 commit 60717fc

File tree

3 files changed

+6
-4
lines changed

3 files changed

+6
-4
lines changed

NEWS

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@ PHP NEWS
88

99
- PCRE:
1010
. Update bundled PCRE2 to 10.39. (cmb)
11+
. Fixed bug #74604 (Out of bounds in php_pcre_replace_impl). (cmb, Dmitry)
1112

1213
- Standard:
1314
. Fixed bug #81659 (stream_get_contents() may unnecessarily overallocate).

Zend/zend_string.h

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -89,7 +89,8 @@ END_EXTERN_C()
8989

9090
#define _ZSTR_STRUCT_SIZE(len) (_ZSTR_HEADER_SIZE + len + 1)
9191

92-
#define ZSTR_MAX_LEN (SIZE_MAX - ZEND_MM_ALIGNED_SIZE(_ZSTR_HEADER_SIZE + 1))
92+
#define ZSTR_MAX_OVERHEAD (ZEND_MM_ALIGNED_SIZE(_ZSTR_HEADER_SIZE + 1))
93+
#define ZSTR_MAX_LEN (SIZE_MAX - ZSTR_MAX_OVERHEAD)
9394

9495
#define ZSTR_ALLOCA_ALLOC(str, _len, use_heap) do { \
9596
(str) = (zend_string *)do_alloca(ZEND_MM_ALIGNED_SIZE_EX(_ZSTR_STRUCT_SIZE(_len), 8), (use_heap)); \

ext/pcre/php_pcre.c

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1725,7 +1725,7 @@ PHPAPI zend_string *php_pcre_replace_impl(pcre_cache_entry *pce, zend_string *su
17251725
}
17261726

17271727
if (new_len >= alloc_len) {
1728-
alloc_len = zend_safe_address_guarded(2, new_len, 0);
1728+
alloc_len = zend_safe_address_guarded(2, new_len, ZSTR_MAX_OVERHEAD) - ZSTR_MAX_OVERHEAD;
17291729
if (result == NULL) {
17301730
result = zend_string_alloc(alloc_len, 0);
17311731
} else {
@@ -1961,9 +1961,9 @@ static zend_string *php_pcre_replace_func_impl(pcre_cache_entry *pce, zend_strin
19611961
pcre2_get_mark(match_data), flags);
19621962

19631963
ZEND_ASSERT(eval_result);
1964-
new_len = zend_safe_address_guarded(1, ZSTR_LEN(eval_result), new_len);
1964+
new_len = zend_safe_address_guarded(1, ZSTR_LEN(eval_result) + ZSTR_MAX_OVERHEAD, new_len) -ZSTR_MAX_OVERHEAD;
19651965
if (new_len >= alloc_len) {
1966-
alloc_len = zend_safe_address_guarded(2, new_len, 0);
1966+
alloc_len = zend_safe_address_guarded(2, new_len, ZSTR_MAX_OVERHEAD) - ZSTR_MAX_OVERHEAD;
19671967
if (result == NULL) {
19681968
result = zend_string_alloc(alloc_len, 0);
19691969
} else {

0 commit comments

Comments
 (0)