Skip to content

Commit 5f870f2

Browse files
committed
Drop TODO Comments
1 parent ec13381 commit 5f870f2

File tree

1 file changed

+0
-5
lines changed

1 file changed

+0
-5
lines changed

ext/pgsql/pgsql.c

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1780,7 +1780,6 @@ PHP_FUNCTION(pg_fetch_result)
17801780
}
17811781
if (field_name) {
17821782
field_offset = PQfnumber(pgsql_result, ZSTR_VAL(field_name));
1783-
// TODO Split into 2 and ValueError for negative index?
17841783
if (field_offset < 0 || field_offset >= PQnfields(pgsql_result)) {
17851784
php_error_docref(NULL, E_WARNING, "Bad column offset specified");
17861785
RETURN_FALSE;
@@ -2120,7 +2119,6 @@ static void php_pgsql_data_info(INTERNAL_FUNCTION_PARAMETERS, int entry_type)
21202119
pg_result->row = 0;
21212120
}
21222121
pgsql_row = pg_result->row;
2123-
// TODO Split into 2 and ValueError for negative index?
21242122
if (pgsql_row < 0 || pgsql_row >= PQntuples(pgsql_result)) {
21252123
RETURN_FALSE;
21262124
}
@@ -2139,7 +2137,6 @@ static void php_pgsql_data_info(INTERNAL_FUNCTION_PARAMETERS, int entry_type)
21392137

21402138
if (field_name) {
21412139
field_offset = PQfnumber(pgsql_result, ZSTR_VAL(field_name));
2142-
// TODO Split into 2 and ValueError for negative index?
21432140
if (field_offset < 0 || field_offset >= PQnfields(pgsql_result)) {
21442141
php_error_docref(NULL, E_WARNING, "Bad column offset specified");
21452142
RETURN_FALSE;
@@ -2849,7 +2846,6 @@ PHP_FUNCTION(pg_lo_seek)
28492846
if (zend_parse_parameters(argc, "rl|l", &pgsql_id, &offset, &whence) == FAILURE) {
28502847
RETURN_THROWS();
28512848
}
2852-
/* TODO Error for < 0 offset? */
28532849
if (whence != SEEK_SET && whence != SEEK_CUR && whence != SEEK_END) {
28542850
zend_argument_value_error(3, "must be one of PGSQL_SEEK_SET, PGSQL_SEEK_CUR, or PGSQL_SEEK_END");
28552851
RETURN_THROWS();
@@ -3386,7 +3382,6 @@ PHP_FUNCTION(pg_unescape_bytea)
33863382
to = estrndup(tmp, to_len);
33873383
PQfreemem(tmp);
33883384
if (!to) {
3389-
/* TODO Promote to Error? */
33903385
php_error_docref(NULL, E_WARNING,"Invalid parameter");
33913386
RETURN_FALSE;
33923387
}

0 commit comments

Comments
 (0)