Skip to content

Commit 5f3e6e3

Browse files
committed
Fix failing soap tests on Windows
These failures are caused by the fix for GHSA-p99j-rfp4-xqvq. Since the two bug*.phpt tests don't need the "wsdl" query string, and don't even need php-cgi, we just remove the `--GET--` section. The two server*.phpt tests are harder to fix, since during evaluation of the `--SKIPIF--` section, the soap extension can be loaded, but it may not during evaluation of the `--FILE--` section. So for now, we skip these tests on Windows altogether. Co-authored-by: Niels Dossche <7771979+nielsdos@users.noreply.github.com> Closes GH-16084.
1 parent fcbcf2f commit 5f3e6e3

File tree

4 files changed

+12
-4
lines changed

4 files changed

+12
-4
lines changed

ext/soap/tests/bugs/bug27722.phpt

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,6 @@
22
Bug #27722 (Segfault on schema without targetNamespace)
33
--EXTENSIONS--
44
soap
5-
--GET--
6-
wsdl
75
--INI--
86
soap.wsdl_cache_enabled=0
97
--FILE--

ext/soap/tests/bugs/bug27742.phpt

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,6 @@
22
Bug #27742 (WDSL SOAP Parsing Schema bug)
33
--EXTENSIONS--
44
soap
5-
--GET--
6-
wsdl
75
--INI--
86
soap.wsdl_cache_enabled=0
97
--FILE--

ext/soap/tests/server011.phpt

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,11 @@
11
--TEST--
22
SOAP Server 11: bind
3+
--SKIPIF--
4+
<?php
5+
if (PHP_OS_FAMILY === "Windows") {
6+
die("skip currently unsupported on Windows");
7+
}
8+
?>
39
--EXTENSIONS--
410
soap
511
--GET--

ext/soap/tests/server012.phpt

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,11 @@
11
--TEST--
22
SOAP Server 12: WSDL generation
3+
--SKIPIF--
4+
<?php
5+
if (PHP_OS_FAMILY === "Windows") {
6+
die("skip currently unsupported on Windows");
7+
}
8+
?>
39
--EXTENSIONS--
410
soap
511
--GET--

0 commit comments

Comments
 (0)