Fix aarch64 crc32 implementation

nikic · nikic · commit 5f13eff4a24a · 2019-10-23T17:41:59.000+02:00
RETVAL vs RETURN mixup resulted in the fallback implementation
running as well.
diff --git a/ext/standard/crc32.c b/ext/standard/crc32.c
@@ -88,13 +88,13 @@ PHP_NAMED_FUNCTION(php_if_crc32)
 #if defined(__aarch64__)
 	if (has_crc32_insn()) {
 		crc = crc32_aarch64(crc, p, nr);
-		RETVAL_LONG(crc^0xFFFFFFFF);
+		RETURN_LONG(crc^0xFFFFFFFF);
 	}
 #endif
 
 	for (; nr--; ++p) {
 		crc = ((crc >> 8) & 0x00FFFFFF) ^ crc32tab[(crc ^ (*p)) & 0xFF ];
 	}
-	RETVAL_LONG(crc^0xFFFFFFFF);
+	RETURN_LONG(crc^0xFFFFFFFF);
 }
 /* }}} */

Original file line number	Diff line number	Diff line change
`@@ -88,13 +88,13 @@ PHP_NAMED_FUNCTION(php_if_crc32)`
`88`	`88`	`#if defined(__aarch64__)`
`89`	`89`	`if (has_crc32_insn()) {`
`90`	`90`	`crc = crc32_aarch64(crc, p, nr);`
`91`		`- RETVAL_LONG(crc^0xFFFFFFFF);`
	`91`	`+ RETURN_LONG(crc^0xFFFFFFFF);`
`92`	`92`	`}`
`93`	`93`	`#endif`
`94`	`94`
`95`	`95`	`for (; nr--; ++p) {`
`96`	`96`	`crc = ((crc >> 8) & 0x00FFFFFF) ^ crc32tab[(crc ^ (*p)) & 0xFF ];`
`97`	`97`	`}`
`98`		`- RETVAL_LONG(crc^0xFFFFFFFF);`
	`98`	`+ RETURN_LONG(crc^0xFFFFFFFF);`
`99`	`99`	`}`
`100`	`100`	`/* }}} */`