Skip to content

Commit 5e824a8

Browse files
committed
Fix integer overflows on 32-bits
1 parent 254a591 commit 5e824a8

File tree

1 file changed

+7
-7
lines changed

1 file changed

+7
-7
lines changed

ext/exif/exif.c

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -3567,19 +3567,19 @@ static int exif_process_IFD_in_TIFF(image_info_type *ImageInfo, size_t dir_offse
35673567
tag_table_type tag_table = exif_get_tag_table(section_index);
35683568

35693569
if (ImageInfo->ifd_nesting_level > MAX_IFD_NESTING_LEVEL) {
3570-
return FALSE;
3571-
}
3570+
return FALSE;
3571+
}
35723572

3573-
if (ImageInfo->FileSize >= dir_offset+2) {
3573+
if (ImageInfo->FileSize >= 2 && ImageInfo->FileSize - 2 >= dir_offset) {
35743574
sn = exif_file_sections_add(ImageInfo, M_PSEUDO, 2, NULL);
35753575
#ifdef EXIF_DEBUG
35763576
exif_error_docref(NULL EXIFERR_CC, ImageInfo, E_NOTICE, "Read from TIFF: filesize(x%04X), IFD dir(x%04X + x%04X)", ImageInfo->FileSize, dir_offset, 2);
35773577
#endif
35783578
php_stream_seek(ImageInfo->infile, dir_offset, SEEK_SET); /* we do not know the order of sections */
35793579
php_stream_read(ImageInfo->infile, (char*)ImageInfo->file.list[sn].data, 2);
35803580
num_entries = php_ifd_get16u(ImageInfo->file.list[sn].data, ImageInfo->motorola_intel);
3581-
dir_size = 2/*num dir entries*/ +12/*length of entry*/*num_entries +4/* offset to next ifd (points to thumbnail or NULL)*/;
3582-
if (ImageInfo->FileSize >= dir_offset+dir_size) {
3581+
dir_size = 2/*num dir entries*/ +12/*length of entry*/*(size_t)num_entries +4/* offset to next ifd (points to thumbnail or NULL)*/;
3582+
if (ImageInfo->FileSize >= dir_size && ImageInfo->FileSize - dir_size >= dir_offset) {
35833583
#ifdef EXIF_DEBUG
35843584
exif_error_docref(NULL EXIFERR_CC, ImageInfo, E_NOTICE, "Read from TIFF: filesize(x%04X), IFD dir(x%04X + x%04X), IFD entries(%d)", ImageInfo->FileSize, dir_offset+2, dir_size-2, num_entries);
35853585
#endif
@@ -3662,9 +3662,9 @@ static int exif_process_IFD_in_TIFF(image_info_type *ImageInfo, size_t dir_offse
36623662
}
36633663
}
36643664
}
3665-
if (ImageInfo->FileSize >= dir_offset + ImageInfo->file.list[sn].size) {
3665+
if (ImageInfo->FileSize >= ImageInfo->file.list[sn].size && ImageInfo->FileSize - ImageInfo->file.list[sn].size >= dir_offset) {
36663666
if (ifd_size > dir_size) {
3667-
if (dir_offset + ifd_size > ImageInfo->FileSize) {
3667+
if (ImageInfo->FileSize < ifd_size || dir_offset > ImageInfo->FileSize - ifd_size) {
36683668
exif_error_docref(NULL EXIFERR_CC, ImageInfo, E_WARNING, "Error in TIFF: filesize(x%04X) less than size of IFD(x%04X + x%04X)", ImageInfo->FileSize, dir_offset, ifd_size);
36693669
return FALSE;
36703670
}

0 commit comments

Comments
 (0)