Skip to content

Commit 5dc995d

Browse files
committed
Eliminate null return value for Normalizer::normalize()
One error condition was returning null instead of false. Adjust the implementation to look the same way as the exact same check a few lines below.
1 parent e1285c4 commit 5dc995d

File tree

5 files changed

+8
-7
lines changed

5 files changed

+8
-7
lines changed

ext/intl/normalizer/normalizer.stub.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ class Normalizer
88
* @tentative-return-type
99
* @alias normalizer_normalize
1010
*/
11-
public static function normalize(string $string, int $form = Normalizer::FORM_C): string|false|null {}
11+
public static function normalize(string $string, int $form = Normalizer::FORM_C): string|false {}
1212

1313
/**
1414
* @tentative-return-type

ext/intl/normalizer/normalizer_arginfo.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
/* This is a generated file, edit the .stub.php file instead.
2-
* Stub hash: d2c622731e68d201a72f8c94094ec8263427b6de */
2+
* Stub hash: 71dd44d3b839789639c16a4b6d5b2e4f40703a74 */
33

4-
ZEND_BEGIN_ARG_WITH_TENTATIVE_RETURN_TYPE_MASK_EX(arginfo_class_Normalizer_normalize, 0, 1, MAY_BE_STRING|MAY_BE_FALSE|MAY_BE_NULL)
4+
ZEND_BEGIN_ARG_WITH_TENTATIVE_RETURN_TYPE_MASK_EX(arginfo_class_Normalizer_normalize, 0, 1, MAY_BE_STRING|MAY_BE_FALSE)
55
ZEND_ARG_TYPE_INFO(0, string, IS_STRING, 0)
66
ZEND_ARG_TYPE_INFO_WITH_DEFAULT_VALUE(0, form, IS_LONG, 0, "Normalizer::FORM_C")
77
ZEND_END_ARG_INFO()

ext/intl/normalizer/normalizer_normalize.c

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -162,9 +162,10 @@ PHP_FUNCTION( normalizer_normalize )
162162
* (U_STRING_NOT_TERMINATED_WARNING usually means that the input string is empty).
163163
*/
164164
if( U_FAILURE(status) && status != U_BUFFER_OVERFLOW_ERROR && status != U_STRING_NOT_TERMINATED_WARNING ) {
165+
intl_error_set_custom_msg( NULL, "Error normalizing string", 0 );
165166
efree( uret_buf );
166167
efree( uinput );
167-
RETURN_NULL();
168+
RETURN_FALSE;
168169
}
169170

170171
if ( size_needed > uret_len ) {

ext/intl/php_intl.stub.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -344,7 +344,7 @@ function msgfmt_get_error_message(MessageFormatter $formatter): string {}
344344

345345
/* normalizer */
346346

347-
function normalizer_normalize(string $string, int $form = Normalizer::FORM_C): string|false|null {}
347+
function normalizer_normalize(string $string, int $form = Normalizer::FORM_C): string|false {}
348348

349349
function normalizer_is_normalized(string $string, int $form = Normalizer::FORM_C): bool {}
350350

ext/intl/php_intl_arginfo.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
/* This is a generated file, edit the .stub.php file instead.
2-
* Stub hash: ab16aedec569db2e2ba8d43c86549ef02d2392c4 */
2+
* Stub hash: 131ce191e92704737b4f20d19ddf53c181e590a6 */
33

44
ZEND_BEGIN_ARG_WITH_RETURN_OBJ_INFO_EX(arginfo_intlcal_create_instance, 0, 0, IntlCalendar, 1)
55
ZEND_ARG_INFO_WITH_DEFAULT_VALUE(0, timezone, "null")
@@ -607,7 +607,7 @@ ZEND_END_ARG_INFO()
607607

608608
#define arginfo_msgfmt_get_error_message arginfo_msgfmt_get_locale
609609

610-
ZEND_BEGIN_ARG_WITH_RETURN_TYPE_MASK_EX(arginfo_normalizer_normalize, 0, 1, MAY_BE_STRING|MAY_BE_FALSE|MAY_BE_NULL)
610+
ZEND_BEGIN_ARG_WITH_RETURN_TYPE_MASK_EX(arginfo_normalizer_normalize, 0, 1, MAY_BE_STRING|MAY_BE_FALSE)
611611
ZEND_ARG_TYPE_INFO(0, string, IS_STRING, 0)
612612
ZEND_ARG_TYPE_INFO_WITH_DEFAULT_VALUE(0, form, IS_LONG, 0, "Normalizer::FORM_C")
613613
ZEND_END_ARG_INFO()

0 commit comments

Comments
 (0)