pgsqlSetNoticeCallback: more tests

see #6764 (review)

Author: outtersg

ext/pdo_pgsql/tests/issue78621.inc

@@ -19,4 +19,5 @@ $db->exec("delete from t");
 $db->exec("insert into t values ('ah')");
 var_dump($db->query("select * from t")->fetchAll(PDO::FETCH_ASSOC));
 echo "Done\n";
+$db->rollback();
 ?>

ext/pdo_pgsql/tests/issue78621_closure.phpt

@@ -12,13 +12,29 @@ PDOTest::skip();
 function disp($message) { echo trim($message)."\n"; }
 function attach($db, $prefix = '')
 {
-    $db->pgsqlSetNoticeCallback(function($message) use($prefix) { echo $prefix.trim($message)."\n"; });
-    // https://github.com/php/php-src/pull/4823#pullrequestreview-335623806
-    $eraseCallbackMemoryHere = (object)[1];
+    global $flavor;
+    switch($flavor)
+    {
+        case 0:
+            $db->pgsqlSetNoticeCallback(function($message) use($prefix) { echo $prefix.trim($message)."\n"; });
+            // https://github.com/php/php-src/pull/4823#pullrequestreview-335623806
+            $eraseCallbackMemoryHere = (object)[1];
+            break;
+        case 1:
+            $closure = function($message) use($prefix) { echo $prefix.'('.get_class($this).')'.trim($message)."\n"; };
+            $db->pgsqlSetNoticeCallback($closure->bindTo(new \stdClass));
+            break;
+    }
 }
+echo "Testing with a simple inline closure:\n";
+$flavor = 0;
+require dirname(__FILE__) . '/issue78621.inc';
+echo "Testing with a postbound closure object:\n";
+++$flavor;
 require dirname(__FILE__) . '/issue78621.inc';
 ?>
 --EXPECT--
+Testing with a simple inline closure:
 NOTICE:  I tampered your data, did you know?
 ReNOTICE:  I tampered your data, did you know?
 array(1) {
@@ -29,3 +45,14 @@ array(1) {
   }
 }
 Done
+Testing with a postbound closure object:
+(stdClass)NOTICE:  I tampered your data, did you know?
+Re(stdClass)NOTICE:  I tampered your data, did you know?
+array(1) {
+  [0]=>
+  array(1) {
+    ["a"]=>
+    string(2) "oh"
+  }
+}
+Done

ext/pdo_pgsql/tests/issue78621_method.phpt

@@ -13,17 +13,47 @@ class Logger
 {
     public function disp($message) { echo trim($message)."\n"; }
     public function dispRe($message) { echo "Re".trim($message)."\n"; }
+    public function __call(string $method, array $args)
+    {
+        $realMethod = strtr($method, [ 'whatever' => 'disp' ]);
+        echo "$method trampoline for $realMethod\n";
+        return call_user_func_array([ $this, $realMethod ], $args);
+    }
 }
 $logger = new Logger();
 function attach($db, $prefix = '')
 {
     global $logger;
-    $db->pgsqlSetNoticeCallback(array($logger, 'disp'.$prefix));
+    global $flavor;
+    switch($flavor)
+    {
+        case 0: $db->pgsqlSetNoticeCallback([ $logger, 'disp'.$prefix ]); break;
+        case 1: $db->pgsqlSetNoticeCallback([ $logger, 'whatever'.$prefix ]); break;
+    }
 }
+echo "Testing with method explicitely plugged:\n";
+$flavor = 0;
+require dirname(__FILE__) . '/issue78621.inc';
+echo "Testing with a bit of magic:\n";
+++$flavor;
 require dirname(__FILE__) . '/issue78621.inc';
 ?>
 --EXPECT--
+Testing with method explicitely plugged:
+NOTICE:  I tampered your data, did you know?
+ReNOTICE:  I tampered your data, did you know?
+array(1) {
+  [0]=>
+  array(1) {
+    ["a"]=>
+    string(2) "oh"
+  }
+}
+Done
+Testing with a bit of magic:
+whatever trampoline for disp
 NOTICE:  I tampered your data, did you know?
+whateverRe trampoline for dispRe
 ReNOTICE:  I tampered your data, did you know?
 array(1) {
   [0]=>