Check for empty string

Author: Girgias

ext/intl/resourcebundle/resourcebundle_class.c

@@ -183,7 +183,14 @@ static zval *resource_bundle_array_fetch(
 	intl_error_reset(INTL_DATA_ERROR_P(rb));
 
 	if (offset_str) {
-		// TODO Check is not empty?
+		if (UNEXPECTED(ZSTR_LEN(offset_str) == 0)) {
+			if (offset_arg_num) {
+				zend_argument_value_error(offset_arg_num, "cannot be empty");
+			} else {
+				zend_value_error("Offset cannot be empty");
+			}
+			return NULL;
+		}
 		key = ZSTR_VAL(offset_str);
 		rb->child = ures_getByKey(rb->me, key, rb->child, &INTL_DATA_ERROR_CODE(rb) );
 	} else {

ext/intl/tests/resourcebundle_dimension_errors.phpt

@@ -34,6 +34,11 @@ try {
 } catch (\Throwable $e) {
     echo $e::class, ': ', $e->getMessage(), PHP_EOL;
 }
+try {
+    var_dump($r['']);
+} catch (\Throwable $e) {
+    echo $e::class, ': ', $e->getMessage(), PHP_EOL;
+}
 try {
     /* This can only happen on 64bit */
     if (PHP_INT_SIZE > 4) {
@@ -52,4 +57,5 @@ Error: Cannot use object of type ResourceBundle as array
 string(7) "default"
 TypeError: Cannot access offset of type float on ResourceBundle
 TypeError: Cannot access offset of type stdClass on ResourceBundle
+ValueError: Offset cannot be empty
 ValueError: Index must be between -2147483648 and 2147483647