Use OBJ_RELEASE instead of ZVAL_OBJ + zval_ptr_dtor in php_dom.c (#15052)

nielsdos · web-flow · commit 551c4a3bf822 · 2024-07-21T16:57:05.000+02:00
diff --git a/ext/dom/php_dom.c b/ext/dom/php_dom.c
@@ -1488,9 +1488,7 @@ static void dom_object_namespace_node_free_storage(zend_object *object)
 {
 	dom_object_namespace_node *intern = php_dom_namespace_node_obj_from_obj(object);
 	if (intern->parent_intern != NULL) {
-		zval tmp;
-		ZVAL_OBJ(&tmp, &intern->parent_intern->std);
-		zval_ptr_dtor(&tmp);
+		OBJ_RELEASE(&intern->parent_intern->std);
 	}
 	dom_objects_free_storage(object);
 }

Original file line number	Diff line number	Diff line change
`@@ -1488,9 +1488,7 @@ static void dom_object_namespace_node_free_storage(zend_object *object)`
`1488`	`1488`	`{`
`1489`	`1489`	`dom_object_namespace_node *intern = php_dom_namespace_node_obj_from_obj(object);`
`1490`	`1490`	`if (intern->parent_intern != NULL) {`
`1491`		`- zval tmp;`
`1492`		`- ZVAL_OBJ(&tmp, &intern->parent_intern->std);`
`1493`		`- zval_ptr_dtor(&tmp);`
	`1491`	`+ OBJ_RELEASE(&intern->parent_intern->std);`
`1494`	`1492`	`}`
`1495`	`1493`	`dom_objects_free_storage(object);`
`1496`	`1494`	`}`