Promote warnings to errors in array_column()

Author: Girgias

ext/standard/array.c

@@ -4122,14 +4122,15 @@ zend_bool array_column_param_helper(zval *param,
 
 		case IS_OBJECT:
 			if (!try_convert_to_string(param)) {
+				zend_type_error("Cannot convert key %s to a string", name);
 				return 0;
 			}
 			/* fallthrough */
 		case IS_STRING:
 			return 1;
 
 		default:
-			php_error_docref(NULL, E_WARNING, "The %s key should be either a string or an integer", name);
+			zend_type_error("The %s key should be either a string or an integer", name);
 			return 0;
 	}
 }
@@ -4192,6 +4193,7 @@ PHP_FUNCTION(array_column)
 
 	if ((column && !array_column_param_helper(column, "column")) ||
 	    (index && !array_column_param_helper(index, "index"))) {
+		/* Throw exception ? */
 		RETURN_FALSE;
 	}
 

ext/standard/tests/array/array_column_error.phpt

@@ -10,41 +10,51 @@ Test array_column() function: error conditions
  */
 
 echo "*** Testing array_column() : error conditions ***\n";
-
 echo "\n-- Testing array_column() column key parameter should be a string or an integer (testing bool) --\n";
-var_dump(array_column(array(), true));
+try {
+    var_dump(array_column(array(), true));
+} catch (\TypeError $e) {
+    echo $e->getMessage() . "\n";
+}
+
 
 echo "\n-- Testing array_column() column key parameter should be a string or integer (testing array) --\n";
-var_dump(array_column(array(), array()));
+try {
+    var_dump(array_column(array(), array()));
+} catch (\TypeError $e) {
+    echo $e->getMessage() . "\n";
+}
 
 echo "\n-- Testing array_column() index key parameter should be a string or an integer (testing bool) --\n";
-var_dump(array_column(array(), 'foo', true));
+try {
+    var_dump(array_column(array(), 'foo', true));
+} catch (\TypeError $e) {
+    echo $e->getMessage() . "\n";
+}
 
 echo "\n-- Testing array_column() index key parameter should be a string or integer (testing array) --\n";
-var_dump(array_column(array(), 'foo', array()));
+try {
+    var_dump(array_column(array(), 'foo', array()));
+} catch (\TypeError $e) {
+    echo $e->getMessage() . "\n";
+}
 
-echo "Done\n";
 ?>
---EXPECTF--
+
+DONE
+--EXPECT--
 *** Testing array_column() : error conditions ***
 
 -- Testing array_column() column key parameter should be a string or an integer (testing bool) --
-
-Warning: array_column(): The column key should be either a string or an integer in %s on line %d
-bool(false)
+The column key should be either a string or an integer
 
 -- Testing array_column() column key parameter should be a string or integer (testing array) --
-
-Warning: array_column(): The column key should be either a string or an integer in %s on line %d
-bool(false)
+The column key should be either a string or an integer
 
 -- Testing array_column() index key parameter should be a string or an integer (testing bool) --
-
-Warning: array_column(): The index key should be either a string or an integer in %s on line %d
-bool(false)
+The index key should be either a string or an integer
 
 -- Testing array_column() index key parameter should be a string or integer (testing array) --
+The index key should be either a string or an integer
 
-Warning: array_column(): The index key should be either a string or an integer in %s on line %d
-bool(false)
-Done
+DONE