Skip to content

Commit 53cc92c

Browse files
bukkacmb69
authored andcommitted
Fix failing openssl_private_decrypt tests
We backport 11caf09[1] as a step to get back to a green CI. [1] <11caf09>
1 parent d9d8237 commit 53cc92c

File tree

3 files changed

+14
-14
lines changed

3 files changed

+14
-14
lines changed

ext/openssl/tests/openssl_error_string_basic.phpt

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -118,12 +118,12 @@ expect_openssl_errors('openssl_pkey_get_public', [$err_pem_no_start_line]);
118118
@openssl_private_encrypt("data", $crypted, $private_key_file, 1000);
119119
expect_openssl_errors('openssl_private_encrypt', ['0408F090']);
120120
// private decrypt with failed padding check
121-
@openssl_private_decrypt("data", $crypted, $private_key_file);
122-
expect_openssl_errors('openssl_private_decrypt', ['04065072']);
121+
@openssl_private_decrypt("data", $crypted, $private_key_file, OPENSSL_PKCS1_OAEP_PADDING);
122+
expect_openssl_errors('openssl_private_decrypt', ['04099079']);
123123
// public encrypt and decrypt with failed padding check and padding
124124
@openssl_public_encrypt("data", $crypted, $public_key_file, 1000);
125-
@openssl_public_decrypt("data", $crypted, $public_key_file);
126-
expect_openssl_errors('openssl_private_(en|de)crypt padding', [$err_pem_no_start_line, '0408F090', '04067072']);
125+
@openssl_public_decrypt("data", $crypted, $public_key_file, OPENSSL_PKCS1_OAEP_PADDING);
126+
expect_openssl_errors('openssl_private_(en|de)crypt padding', [$err_pem_no_start_line, '0408F090', '06089093']);
127127

128128
// X509
129129
echo "X509 errors\n";

ext/openssl/tests/openssl_error_string_basic_openssl3.phpt

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -121,12 +121,12 @@ expect_openssl_errors('openssl_pkey_get_public', [$err_pem_no_start_line]);
121121
@openssl_private_encrypt("data", $crypted, $private_key_file, 1000);
122122
expect_openssl_errors('openssl_private_encrypt', ['1C8000A5']);
123123
// private decrypt with failed padding check
124-
@openssl_private_decrypt("data", $crypted, $private_key_file);
125-
expect_openssl_errors('openssl_private_decrypt', ['0200009F', '02000072']);
124+
@openssl_private_decrypt("data", $crypted, $private_key_file, OPENSSL_PKCS1_OAEP_PADDING);
125+
expect_openssl_errors('openssl_private_decrypt', ['02000079']);
126126
// public encrypt and decrypt with failed padding check and padding
127127
@openssl_public_encrypt("data", $crypted, $public_key_file, 1000);
128-
@openssl_public_decrypt("data", $crypted, $public_key_file);
129-
expect_openssl_errors('openssl_private_(en|de)crypt padding', [$err_pem_no_start_line, '02000076', '0200008A', '02000072', '1C880004']);
128+
@openssl_public_decrypt("data", $crypted, $public_key_file, OPENSSL_PKCS1_OAEP_PADDING);
129+
expect_openssl_errors('openssl_private_(en|de)crypt padding', [$err_pem_no_start_line, '1C8000A5']);
130130

131131
// X509
132132
echo "X509 errors\n";

ext/openssl/tests/openssl_private_decrypt_basic.phpt

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -9,22 +9,22 @@ $privkey = "file://" . __DIR__ . "/private_rsa_1024.key";
99
$pubkey = "file://" . __DIR__ . "/public.key";
1010
$wrong = "wrong";
1111

12-
openssl_public_encrypt($data, $encrypted, $pubkey);
13-
var_dump(openssl_private_decrypt($encrypted, $output, $privkey));
12+
openssl_public_encrypt($data, $encrypted, $pubkey, OPENSSL_PKCS1_OAEP_PADDING);
13+
var_dump(openssl_private_decrypt($encrypted, $output, $privkey, OPENSSL_PKCS1_OAEP_PADDING));
1414
var_dump($output);
15-
var_dump(openssl_private_decrypt($encrypted, $output2, $wrong));
15+
var_dump(openssl_private_decrypt($encrypted, $output2, $wrong, OPENSSL_PKCS1_OAEP_PADDING));
1616
var_dump($output2);
17-
var_dump(openssl_private_decrypt($wrong, $output3, $privkey));
17+
var_dump(openssl_private_decrypt($wrong, $output3, $privkey, OPENSSL_PKCS1_OAEP_PADDING));
1818
var_dump($output3);
1919

2020
try {
21-
var_dump(openssl_private_decrypt($encrypted, $output4, array($privkey)));
21+
var_dump(openssl_private_decrypt($encrypted, $output4, array($privkey), OPENSSL_PKCS1_OAEP_PADDING));
2222
var_dump($output4);
2323
} catch (\ValueError $e) {
2424
echo $e->getMessage() . \PHP_EOL;
2525
}
2626

27-
var_dump(openssl_private_decrypt($encrypted, $output5, array($privkey, "")));
27+
var_dump(openssl_private_decrypt($encrypted, $output5, array($privkey, ""), OPENSSL_PKCS1_OAEP_PADDING));
2828
var_dump($output5);
2929
?>
3030
--EXPECTF--

0 commit comments

Comments
 (0)