Fix bug #66588: SplFileObject::fgetcsv incorrectly returns a row on premature EOF

Make sure the behavior is the same regardless of whether there is
a trailing newline and whether the input is a stream or not.

Closes GH-7539.

Author: Aliaksandr Bystry

NEWS

@@ -10,6 +10,8 @@ PHP                                                                        NEWS
 - Standard:
   . Fixed bug #81491 (Incorrectly using libsodium for argon2 hashing).
     (Dan Pock)
+  . Fixed bug #66588 (SplFileObject::fgetcsv incorrectly returns a row on
+    premature EOF). (Aliaksandr Bystry)
 
 - Streams:
   . Fixed bug #81475 (stream_isatty emits warning with attached stream wrapper).

ext/standard/file.c

@@ -2144,12 +2144,7 @@ PHPAPI void php_fgetcsv(php_stream *stream, char delimiter, char enclosure, int
 									 * assign all the data from the start of
 									 * the enclosure to end of data to the
 									 * last element */
-									if ((size_t)temp_len > (size_t)(limit - buf)) {
-										goto quit_loop_2;
-									}
-									zend_array_destroy(Z_ARR_P(return_value));
-									RETVAL_FALSE;
-									goto out;
+									goto quit_loop_2;
 								}
 
 								temp_len += new_len;
@@ -2300,7 +2295,6 @@ PHPAPI void php_fgetcsv(php_stream *stream, char delimiter, char enclosure, int
 		add_next_index_stringl(return_value, temp, comp_end - temp);
 	} while (inc_len > 0);
 
-out:
 	efree(temp);
 	if (stream) {
 		efree(buf);

ext/standard/tests/file/bug66588.phpt

@@ -0,0 +1,30 @@
+--TEST--
+Bug #66588 SplFileObject::fgetcsv incorrectly returns a row on premature EOF
+--DESCRIPTION--
+This bug is about the different behavior with and without trailing newline both should behave the same,
+and neither should return FALSE.
+--FILE--
+<?php
+
+$s = fopen("php://memory", "w+");
+fwrite($s, "\",bar");
+rewind($s);
+var_dump(fgetcsv($s));
+fclose($s);
+
+$s = fopen("php://memory", "w+");
+fwrite($s, "\",bar\n");
+rewind($s);
+var_dump(fgetcsv($s));
+fclose($s);
+?>
+--EXPECT--
+array(1) {
+  [0]=>
+  string(4) ",bar"
+}
+array(1) {
+  [0]=>
+  string(5) ",bar
+"
+}

ext/standard/tests/file/fgetcsv.phpt

@@ -165,4 +165,9 @@ array(2) {
   string(4) "bbb
 "
 }
-bool(false)
+array(2) {
+  [0]=>
+  string(3) "aaa"
+  [1]=>
+  string(3) "bbb"
+}