Skip to content

Commit 5236551

Browse files
authored
[skip ci] Remove obsolete guideline how to comment out code (#14621)
This can lead to undefined warnings when building with -Wundef and using undefined FOO macro in #if condition. Also such code disabling should not be encouraged exactly.
1 parent ff58a7f commit 5236551

File tree

1 file changed

+0
-5
lines changed

1 file changed

+0
-5
lines changed

CODING_STANDARDS.md

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -55,11 +55,6 @@ rewritten to comply with these rules.
5555
the source. Although the `PHP_*` macros are mostly aliased to the `ZEND_*`
5656
macros it gives a better understanding on what kind of macro you're calling.
5757

58-
1. When commenting out code using a `#if` statement, do NOT use `0` only.
59-
Instead, use `"<git username here>_0"`. For example, `#if FOO_0`,
60-
where `FOO` is your git user `foo`. This allows easier tracking of why
61-
code was commented out, especially in bundled libraries.
62-
6358
1. Do not define functions that are not available. For instance, if a library is
6459
missing a function, do not define the PHP version of the function, and do
6560
not raise a run-time error about the function not existing. End users should

0 commit comments

Comments
 (0)